[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230307100903.71e2d9b2@xps-13>
Date: Tue, 7 Mar 2023 10:09:03 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Denis Kirjanov <dkirjanov@...e.de>
Cc: Dongliang Mu <dzm91@...t.edu.cn>,
Alexander Aring <alex.aring@...il.com>,
Stefan Schmidt <stefan@...enfreihafen.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
syzbot+bd85b31816913a32e473@...kaller.appspotmail.com,
linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ieee802154: fix a null pointer in
nl802154_trigger_scan
Hello,
dkirjanov@...e.de wrote on Tue, 7 Mar 2023 11:43:46 +0300:
> On 3/7/23 10:30, Dongliang Mu wrote:
> > There is a null pointer dereference if NL802154_ATTR_SCAN_TYPE is
> > not set by the user.
> >
> > Fix this by adding a null pointer check.
Thanks for the patch! This has been fixed already:
https://lore.kernel.org/linux-wpan/20230301154450.547716-1-miquel.raynal@bootlin.com/T/#u
> > Reported-and-tested-by: syzbot+bd85b31816913a32e473@...kaller.appspotmail.com
Just for reference, this tag shall not be used:
"Please do not use combined tags, e.g.
``Reported-and-tested-by``"
Documentation/process/maintainer-tip.rst
> > Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
>
> Please add a Fixes: tag
>
> > ---
> > net/ieee802154/nl802154.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> > index 2215f576ee37..1cf00cffd63f 100644
> > --- a/net/ieee802154/nl802154.c
> > +++ b/net/ieee802154/nl802154.c
> > @@ -1412,7 +1412,8 @@ static int nl802154_trigger_scan(struct sk_buff *skb, struct genl_info *info)
> > return -EOPNOTSUPP;
> > }
> >
> > - if (!nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) {
> > + if (!info->attrs[NL802154_ATTR_SCAN_TYPE] ||
> > + !nla_get_u8(info->attrs[NL802154_ATTR_SCAN_TYPE])) {
> > NL_SET_ERR_MSG(info->extack, "Malformed request, missing scan type");
> > return -EINVAL;
> > }
Thanks,
Miquèl
Powered by blists - more mailing lists