linux-kernel - Re: [PATCH] scsi: mpt3sas: fix NULL pointer access in mpt3sas_transport_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1mt4pmj8g.fsf@ca-mkp.ca.oracle.com>
Date:   Mon, 06 Mar 2023 20:42:14 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Ranjan Kumar <ranjan.kumar@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Cc:     Wenchao Hao <haowenchao2@...wei.com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        <MPT-FusionLinux.pdl@...adcom.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linfeilong@...wei.com>
Subject: Re: [PATCH] scsi: mpt3sas: fix NULL pointer access in
 mpt3sas_transport_port_add()


Ranjan/Sreekanth,

> port is allocated by sas_port_alloc_num() and rphy is allocated by
> sas_end_device_alloc() or sas_expander_alloc() which may return NULL,
> so we need to check the rphy to avoid possible NULL pointer access.
>
> If sas_rphy_add() called with failure rphy is set to NULL, we would
> access the rphy in next lines which would also result NULL pointer
> access.
>
> Fix commit 78316e9dfc24 ("scsi: mpt3sas: Fix possible resource leaks
> in mpt3sas_transport_port_add()")

Please review!

-- 
Martin K. Petersen	Oracle Linux Engineering