linux-kernel - Re: [PATCH] firmware: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca7a9708-8909-d663-d02f-240f8087aa9a@linaro.org>
Date:   Tue, 7 Mar 2023 14:13:53 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org
Cc:     marijn.suijten@...ainline.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom_scm: Add SM6375 compatible



On 7.03.2023 02:22, Konrad Dybcio wrote:
> While it was introduced in bindings, requiring a core clock, and added
> into the DT, this compatible was apparently forgotten about on the driver
> side of things. Fix it.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>  drivers/firmware/qcom_scm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 916a0c2fc903..2e8961c84b68 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1494,6 +1494,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
>  	},
>  	{ .compatible = "qcom,scm-msm8994" },
>  	{ .compatible = "qcom,scm-msm8996" },
> +	{ .compatible = "qcom,scm-sm6375", .data = (void *)SCM_HAS_CORE_CLK },
On a second thought, maybe the qcom,scm compatible could optionally consume
all three clocks with schema guarding how many should be used, to prevent
having to add nonsensical compatibles?

Konrad
>  	{ .compatible = "qcom,scm" },
>  	{}
>  };