linux-kernel - Re: [PATCH] drm/amd/display: remove unused variable res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 10:39:47 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     harry.wentland@....com, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
        daniel@...ll.ch, lyude@...hat.com, Wayne.Lin@....com,
        hersenxs.wu@....com, hamza.mahfooz@....com, Jerry.Zuo@....com,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: remove unused variable res_pool

Applied.  Thanks!

On Wed, Mar 8, 2023 at 9:10 AM Tom Rix <trix@...hat.com> wrote:
>
> With gcc and W=1, there is this error
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:1214:31:
>   error: variable ‘res_pool’ set but not used [-Werror=unused-but-set-variable]
>  1214 |         struct resource_pool *res_pool;
>       |                               ^~~~~~~~
>
> Since res_pool is unused, remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 2739bef9b90c..4b9b5e4050fc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -1211,7 +1211,6 @@ static int pre_compute_mst_dsc_configs_for_state(struct drm_atomic_state *state,
>         bool computed_streams[MAX_PIPES];
>         struct amdgpu_dm_connector *aconnector;
>         struct drm_dp_mst_topology_mgr *mst_mgr;
> -       struct resource_pool *res_pool;
>         int link_vars_start_index = 0;
>         int ret = 0;
>
> @@ -1220,7 +1219,6 @@ static int pre_compute_mst_dsc_configs_for_state(struct drm_atomic_state *state,
>
>         for (i = 0; i < dc_state->stream_count; i++) {
>                 stream = dc_state->streams[i];
> -               res_pool = stream->ctx->dc->res_pool;
>
>                 if (stream->signal != SIGNAL_TYPE_DISPLAY_PORT_MST)
>                         continue;
> --
> 2.27.0
>