linux-kernel - Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230308160723.rhgsghtxxkfhbsu6@pengutronix.de>
Date:   Wed, 8 Mar 2023 17:07:23 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        thierry.reding@...il.com, matthias.bgg@...il.com,
        weiqing.kong@...iatek.com, jitao.shi@...iatek.com,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot

On Wed, Mar 08, 2023 at 04:43:25PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 08, 2023 at 03:55:59PM +0100, AngeloGioacchino Del Regno wrote:
> > Il 08/03/23 15:50, Greg Kroah-Hartman ha scritto:
> > > On Wed, Mar 08, 2023 at 12:46:07PM +0100, AngeloGioacchino Del Regno wrote:
> > > > Il 23/02/23 15:16, AngeloGioacchino Del Regno ha scritto:
> > > > > Il 23/01/23 17:06, AngeloGioacchino Del Regno ha scritto:
> > > > > > Since the pwm-mtk-disp driver was fixed to get PWM_EN state from the
> > > > > > right register, an old two-wrongs-make-one-right issue emerged: as a
> > > > > > result, MT8192 Asurada Spherion got no backlight at boot unless a
> > > > > > suspend/resume cycle was performed.
> > > > > > Also, the backlight would sometimes not get updated with the requested
> > > > > > value, requiring the user to change it back and forth until it worked.
> > > > > > 
> > > > > > This series fixes both of the aforementioned issues found on MT8192.
> > > > > > 
> > > > > > AngeloGioacchino Del Regno (2):
> > > > > >     pwm: mtk-disp: Disable shadow registers before setting backlight
> > > > > >       values
> > > > > >     pwm: mtk-disp: Configure double buffering before reading in
> > > > > >       .get_state()
> > > > > > 
> > > > > >    drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++-----------
> > > > > >    1 file changed, 23 insertions(+), 11 deletions(-)
> > > > > > 
> > > > > 
> > > > > Gentle ping for this one: this is fixing backlight issues on multiple MediaTek
> > > > > SoCs and was well tested.
> > > > > 
> > > > > Thanks,
> > > > > Angelo
> > > > 
> > > > Since this series was sent more than one month ago, and since this fixes broken
> > > > backlight on a number of Chromebooks with MT8183 and MT8192 SoCs, and seen the
> > > > urgency of getting these fixes in, I'm adding Greg to the loop.
> > > 
> > > $ ./scripts/get_maintainer.pl drivers/pwm/pwm-mtk-disp.c
> > > Thierry Reding <thierry.reding@...il.com> (maintainer:PWM SUBSYSTEM)
> > > "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de> (reviewer:PWM SUBSYSTEM)
> > > Matthias Brugger <matthias.bgg@...il.com> (maintainer:ARM/Mediatek SoC support)
> > > AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> (reviewer:ARM/Mediatek SoC support)
> > > linux-pwm@...r.kernel.org (open list:PWM SUBSYSTEM)
> > > linux-kernel@...r.kernel.org (open list:ARM/Mediatek SoC support)
> > > linux-arm-kernel@...ts.infradead.org (moderated list:ARM/Mediatek SoC support)
> > > linux-mediatek@...ts.infradead.org (moderated list:ARM/Mediatek SoC support)
> > > 
> > > I don't see my name in there, did I become the PWM maintainer somehow?
> > > 
> > > What's wrong with Thierry taking this like normal?
> > > 
> > 
> > Nothing wrong with that. I felt like this series got ignored as I've never
> > received any reply from Thierry, even though it's a Fixes series that I deem
> > to be moderately urgent; that's why I added you to the loop.
> 
> Then ask Thierry and Uwe, what would you want to have happen if you were
> the maintainer of a subsystem?
> 
> > If that created unnecessary noise, I'm extremely sorry and won't happen again.
> 
> Not noise, just confusion on my part.  I'm glad to take patches that
> have no obvious maintainers, or maintainers that have disappeared, but
> that doesn't seem to be the case here.

I'm aware that there is a big backlog on PWM patches. I'm trying to
catch up but there is only so much time. Sorry this results in delays
for you (and others), I'm not happy with this situation either.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)