linux-kernel - Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac8fed53-6f05-6ec7-9ef5-61110cd83c0b@amd.com>
Date:   Wed, 8 Mar 2023 11:11:22 -0500
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Qingqing Zhuo <qingqing.zhuo@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     Emma Anholt <emma@...olt.net>, David Airlie <airlied@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Daniel Vetter <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drm/vc4: Fix build error with undefined label

+ vc4 maintainers

On 3/8/23 04:34, Qingqing Zhuo wrote:
> [Why]
> drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’:
> drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined
> 
> [How]
> update err_disable_runtime_pm to err_put_runtime_pm.
> 
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@....com>
> ---
>   drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 9e145690c480..edf882360d24 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -3445,7 +3445,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
>   	 */
>   	ret = pm_runtime_resume_and_get(dev);
>   	if (ret)
> -		goto err_disable_runtime_pm;
> +		goto err_put_runtime_pm;
>   
>   	if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
>   	     of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1")) &&

-- 
Hamza