linux-kernel - Re: [PATCH 6.2 0000/1001] 6.2.3-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230308180111.cxa2fdyfwbqwzdgg@pali>
Date:   Wed, 8 Mar 2023 19:01:11 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Daniel Díaz <daniel.diaz@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        christophe.leroy@...roup.eu, mpe@...erman.id.au
Subject: Re: [PATCH 6.2 0000/1001] 6.2.3-rc1 review

On Tuesday 07 March 2023 18:01:42 Daniel Díaz wrote:
> Hello!
> 
> On 07/03/23 10:46, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.2.3 release.
> > There are 1001 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu, 09 Mar 2023 16:57:34 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.2.3-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.2.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> We see a regression with PowerPC's ppc64e_defconfig, using GCC 8 and GCC 12:
> -----8<-----
> powerpc64le-linux-gnu-gcc: error: missing argument to '-mcpu='
> powerpc64le-linux-gnu-gcc: error: missing argument to '-mcpu='
> make[2]: *** [/builds/linux/arch/powerpc/boot/Makefile:237: arch/powerpc/boot/crt0.o] Error 1
> make[2]: *** [/builds/linux/arch/powerpc/boot/Makefile:237: arch/powerpc/boot/crtsavres.o] Error 1
> powerpc64le-linux-gnu-gcc: error: missing argument to '-mcpu='
> make[2]: *** [/builds/linux/arch/powerpc/boot/Makefile:235: arch/powerpc/boot/cuboot.o] Error 1
> [...]
> make[2]: Target 'arch/powerpc/boot/zImage' not remade because of errors.
> make[1]: *** [/builds/linux/arch/powerpc/Makefile:247: zImage] Error 2
> make[1]: Target '__all' not remade because of errors.
> make: *** [Makefile:242: __sub-make] Error 2
> make: Target '__all' not remade because of errors.
> ----->8-----
> 
> Bisection points to "powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage" (upstream ff7c76f66d8bad4e694c264c789249e1d3a8205d).

Hello! You hit another issue that CONFIG_TARGET_CPU_BOOL is set but
CONFIG_TARGET_CPU is not. This issue was fixed in upstream by commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45f7091aac3546ef8112bf62836650ca0bbf0b79

See discussion about that issue:
https://lore.kernel.org/linuxppc-dev/20221208191602.diywrt3g2f6zmt4s@pali/

Can you check that above commit was also backported during your testing?
If not then apply it too and test again.

Commit ff7c76f66d8bad4e694c264c789249e1d3a8205d is needed to backport
because it is fixing compile error issue for e500v2 platforms when
compiling kernel with e500v2 cross compiler.

> Reproducer:
>   tuxmake \
>     --runtime podman \
>     --target-arch powerpc \
>     --toolchain gcc-8 \
>     --kconfig ppc64e_defconfig \
>     config debugkernel dtbs kernel modules xipkernel
> 
> Greetings!
> 
> Daniel Díaz
> daniel.diaz@...aro.org
> 
>