linux-kernel - Re: [PATCH 02/32] pata_parport-bpck6: remove useless range check from read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f41885da-ca87-777d-8d10-97afa140a416@omp.ru>
Date:   Wed, 8 Mar 2023 21:03:36 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Ondrej Zary <linux@...y.sk>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Tim Waugh <tim@...erelk.net>, <linux-block@...r.kernel.org>,
        <linux-parport@...ts.infradead.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/32] pata_parport-bpck6: remove useless range check from
 read/write_regr

On 3/8/23 1:45 AM, Ondrej Zary wrote:

> bpck6_read_regr() and bpck6_write_regr() check values of cont and reg
> but there's no point in doing that. They can only be called with
> a fixed set of values. Remove the checks.
> 
> Signed-off-by: Ondrej Zary <linux@...y.sk>


Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey