linux-kernel - Re: [PATCH V2 4/6] dt-bindings: timestamp: Add Tegra234 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5e897e5-4cb9-d50f-47a8-ffb8bd8774cb@kernel.org>
Date:   Wed, 8 Mar 2023 20:05:11 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Dipen Patel <dipenp@...dia.com>, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-gpio@...r.kernel.org,
        linus.walleij@...aro.org, devicetree@...r.kernel.org,
        linux-doc@...r.kernel.org, robh+dt@...nel.org,
        timestamp@...ts.linux.dev
Subject: Re: [PATCH V2 4/6] dt-bindings: timestamp: Add Tegra234 support

On 08/03/2023 19:45, Dipen Patel wrote:
> On 2/16/23 6:17 AM, Krzysztof Kozlowski wrote:
>> On 14/02/2023 12:55, Dipen Patel wrote:
>>> Added timestamp provider support for the Tegra234 in devicetree
>>> bindings.
>>
>> 1. Your commit does much more. You need to explain it why you drop some
>> property.
> ACK, will address it next patch
>>
>> 2. Bindings go before its usage (in the patchset).
> Ack...
>>
>> 3. Please use scripts/get_maintainers.pl to get a list of necessary
>> people and lists to CC.  It might happen, that command when run on an
>> older kernel, gives you outdated entries.  Therefore please be sure you
>> base your patches on recent Linux kernel.
> It is based on recent linux at the time patch series was sent...

That's good but then why you do not use scripts/get_maintainers.pl? The
hint about recent kernel was just a hint... Just do not invent addresses
by yourself and use the tool to get them right.

(...)

>>> +  properties:
>>> +    compatible:
>>> +      contains:
>>> +        enum:
>>> +          - nvidia,tegra194-gte-aon
>>
>> This is an ABI break. Does your driver handle it?
> yes, handling patch is part of this patch series.

Can you point me to the code which does it? I see "return -ENODEV;", so
I think you do not handle ABI break. I could miss something but since
you disagree with me, please at least bring some arguments...


Best regards,
Krzysztof