linux-kernel - Re: [PATCH] rdma/qib: Remove deprecated kmap() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <110becd9-3511-b7ab-f34c-1a4fe7fc9e82@cornelisnetworks.com>
Date:   Wed, 8 Mar 2023 15:24:55 -0500
From:   Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
To:     Ira Weiny <ira.weiny@...el.com>, Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rdma/qib: Remove deprecated kmap() call

On 3/7/23 12:15 PM, Ira Weiny wrote:
> kmap() has been deprecated in favor of the kmap_local_page() call.
> kmap_local_page() is thread local.
> 
> In the sdma coalesce case the page allocated is potentially free'ed in a
> different context through qib_sdma_get_complete() ->
> qib_user_sdma_make_progress().  The use of kmap_local_page() is
> inappropriate in this call path.  However, the page is allocated using
> GFP_KERNEL and will never be from highmem.
> 
> Remove the use of kmap calls and use page_address() in this case.
> 
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>

Acked-by: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>