[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67b59032-c94b-e69e-57ed-45784e809df4@cornelisnetworks.com>
Date: Wed, 8 Mar 2023 15:37:41 -0500
From: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
To: Bjorn Helgaas <helgaas@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
Leon Romanovsky <leon@...nel.org>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 1/2] IB/hfi1: Drop redundant
pci_enable_pcie_error_reporting()
On 3/7/23 2:32 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.
>
> Note that this only controls ERR_* Messages from the device. An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
Powered by blists - more mailing lists