lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230308204243.GA3735537-robh@kernel.org>
Date:   Wed, 8 Mar 2023 14:42:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     arinc9.unal@...il.com
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Arınç ÜNAL <arinc.unal@...nc9.com>,
        linux-mediatek@...ts.infradead.org, linux-mips@...r.kernel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...nel.org>,
        William Dean <williamsukatube@...il.com>,
        Daniel Golle <daniel@...rotopia.org>,
        Daniel Santos <daniel.santos@...ox.com>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Sean Wang <sean.wang@...iatek.com>, erkin.bozoglu@...ont.com
Subject: Re: [PATCH 07/20] dt-bindings: pinctrl: ralink: improve bindings

On Fri, Mar 03, 2023 at 03:28:36AM +0300, arinc9.unal@...il.com wrote:
> From: Arınç ÜNAL <arinc.unal@...nc9.com>
> 
> Move additionalProperties to the top. It's easier to read than after a long
> indented section.
> 
> Drop the quotes from the referred schemas.

Not the greatest subject as every change improves something and bindings 
is stated twice. Hard to come up with something better since you've 
combined 2 different kinds of changes which you shouldn't do either. So 
I'd split this patch into 2.

> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
>  .../bindings/pinctrl/ralink,mt7620-pinctrl.yaml          | 9 ++++-----
>  .../bindings/pinctrl/ralink,mt7621-pinctrl.yaml          | 9 ++++-----
>  .../bindings/pinctrl/ralink,rt2880-pinctrl.yaml          | 9 ++++-----
>  .../bindings/pinctrl/ralink,rt305x-pinctrl.yaml          | 9 ++++-----
>  .../bindings/pinctrl/ralink,rt3883-pinctrl.yaml          | 9 ++++-----
>  5 files changed, 20 insertions(+), 25 deletions(-)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ