linux-kernel - Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <202303082348.29416.linux@zary.sk>
Date:   Wed, 8 Mar 2023 23:48:29 +0100
From:   Ondrej Zary <linux@...y.sk>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Baoquan He <bhe@...hat.com>, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-mm@...ck.org, arnd@...db.de,
        mpe@...erman.id.au, geert@...ux-m68k.org, hch@...radead.org,
        Helge Deller <deller@....de>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

On Wednesday 08 March 2023 21:01:09 Luis Chamberlain wrote:
> On Wed, Mar 08, 2023 at 09:07:07PM +0800, Baoquan He wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> > extension, and on ia64 with its slightly unconventional ioremap()
> > behavior, everywhere else this is the same as ioremap() anyway.
> > 
> > Change the only driver that still references ioremap_uc() to only do so
> > on x86-32/ia64 in order to allow removing that interface at some
> > point in the future for the other architectures.
> > 
> > On some architectures, ioremap_uc() just returns NULL, changing
> > the driver to call ioremap() means that they now have a chance
> > of working correctly.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > Cc: Helge Deller <deller@....de>
> > Cc: Thomas Zimmermann <tzimmermann@...e.de>
> > Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> > Cc: linux-fbdev@...r.kernel.org
> > Cc: dri-devel@...ts.freedesktop.org
> 
> Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>
> 
> Is anyone using this driver these days? How often do fbdev drivers get
> audited to see what can be nuked?

Older servers have integrated ATI Rage XL chips and this is the only driver for it.

-- 
Ondrej Zary