[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB6083D732726BE2BF06DAC3CEFCB49@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Wed, 8 Mar 2023 00:36:39 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Torvalds, Linus" <torvalds@...ux-foundation.org>
CC: Jakub Jelinek <jakub@...hat.com>,
Segher Boessenkool <segher@...nel.crashing.org>,
Peter Zijlstra <peterz@...radead.org>,
"Nick Desaulniers" <ndesaulniers@...gle.com>,
"Eranian, Stephane" <eranian@...gle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Chatre, Reinette" <reinette.chatre@...el.com>,
"Yu, Fenghua" <fenghua.yu@...el.com>,
"peternewman@...gle.com" <peternewman@...gle.com>,
"james.morse@....com" <james.morse@....com>,
"babu.moger@....com" <babu.moger@....com>,
"ananth.narayan@....com" <ananth.narayan@....com>,
"vschneid@...hat.com" <vschneid@...hat.com>,
Nathan Chancellor <nathan@...nel.org>,
clang-built-linux <llvm@...ts.linux.dev>,
Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>,
"linux-toolchains@...r.kernel.org" <linux-toolchains@...r.kernel.org>
Subject: RE: [PATCH] x86/resctrl: avoid compiler optimization in
__resctrl_sched_in
> I wonder if checkpatch could catch missing "inline" on static
> function definitions in header files?
Some casual use of grep shows that resctrl isn't the only offender.
There are many non-inline static functions in header files.
A few hundred scattered across core kernel code, drivers and most
architectures. E.g. a dozen in arch/x86/include/asm/floppy.h.
static irqreturn_t floppy_hardint(int irq, void *dev_id)
static void fd_disable_dma(void)
static int vdma_request_dma(unsigned int dmanr, const char *device_id)
static void vdma_nop(unsigned int dummy)
static int vdma_get_dma_residue(unsigned int dummy)
static int fd_request_irq(void)
static unsigned long dma_mem_alloc(unsigned long size)
static unsigned long vdma_mem_alloc(unsigned long size)
static void _fd_dma_mem_free(unsigned long addr, unsigned long size)
static void _fd_chose_dma_mode(char *addr, unsigned long size)
static int vdma_dma_setup(char *addr, unsigned long size, int mode, int io)
static int hard_dma_setup(char *addr, unsigned long size, int mode, int io)
-Tony
Powered by blists - more mailing lists