linux-kernel - Re: [PATCH] reset: sti: rely on regmap_field_read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ef16f3f-4293-b804-e31d-352a2c394df8@foss.st.com>
Date:   Wed, 8 Mar 2023 09:49:20 +0100
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Alain Volmat <avolmat@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] reset: sti: rely on regmap_field_read_poll_timeout for
 ack wait

Hi Alain

On 2/10/23 23:43, Alain Volmat wrote:
> Use regmap_field_read_poll_timeout function when waiting for the
> ack bit upon performing the reset control.
> 
> Signed-off-by: Alain Volmat <avolmat@...com>
> ---
>  drivers/reset/sti/reset-syscfg.c | 18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c
> index b4b46e0f207e..c1ba04f6f155 100644
> --- a/drivers/reset/sti/reset-syscfg.c
> +++ b/drivers/reset/sti/reset-syscfg.c
> @@ -64,22 +64,12 @@ static int syscfg_reset_program_hw(struct reset_controller_dev *rcdev,
>  		return err;
>  
>  	if (ch->ack) {
> -		unsigned long timeout = jiffies + msecs_to_jiffies(1000);
>  		u32 ack_val;
>  
> -		while (true) {
> -			err = regmap_field_read(ch->ack, &ack_val);
> -			if (err)
> -				return err;
> -
> -			if (ack_val == ctrl_val)
> -				break;
> -
> -			if (time_after(jiffies, timeout))
> -				return -ETIME;
> -
> -			cpu_relax();
> -		}
> +		err = regmap_field_read_poll_timeout(ch->ack, ack_val, (ack_val == ctrl_val),
> +						     100, USEC_PER_SEC);
> +		if (err)
> +			return err;
>  	}
>  
>  	return 0;

Reviewed-by: Patrice Chotard <patrice.chotard@...s.st.com>
Thanks
Patrice