linux-kernel - Re: [PATCH 2/6] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dcf2b583-4b42-85b7-4de4-fb0b5011af5e@linaro.org>
Date:   Wed, 8 Mar 2023 11:31:53 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Alexandre Mergnat <amergnat@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Yong Wu <yong.wu@...iatek.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: memory-controllers: mediatek,smi-larb:
 add mt8365

On 08/03/2023 11:30, Krzysztof Kozlowski wrote:
> On 07/03/2023 14:46, Alexandre Mergnat wrote:
>> Add binding description for mediatek,mt8365-smi-larb
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
>> ---
>>  .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml     | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> index 5f4ac3609887..aee7f6cf1300 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> @@ -34,6 +34,10 @@ properties:
>>            - const: mediatek,mt7623-smi-larb
>>            - const: mediatek,mt2701-smi-larb
>>  
>> +      - items:
>> +          - const: mediatek,mt8365-smi-larb
>> +          - const: mediatek,mt8186-smi-larb
> 
> You need to fix the allOf:if. It expects single item, so you need to add
> contains like for mt2701.

Wait, this was about common. LARB looks ok, but double check.

Best regards,
Krzysztof