linux-kernel - Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2f9cd15-b303-882a-d4e0-36d1f6d155a8@linaro.org>
Date:   Wed, 8 Mar 2023 11:38:16 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     zhuyinbo <zhuyinbo@...ngson.cn>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>, wanghongliang@...ngson.cn,
        loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock
 index

On 08/03/2023 10:24, zhuyinbo wrote:
>>>> That's an ABI break and commit msg does not explain it.
>>> you meaning is that need add a explanation in commit msg that why
>> You need good explanation to break the ABI. I don't understand the
>> commit msg, but anyway I could not find there justification for ABI
>> break. If you do not have good justification, don't break the ABI,
> 
> The commit msg is the patch commit  log,  and I maybe not got it about 
> break the ABI.  You said about "break the ABI"
> 
> is whether is location issue about "LOONGSON2_BOOT_CLK"?   if yes,   the 
> LOONGSON2_BOOT_CLK was placed
> 
> after LOONGSON2_PIX1_PLL that is due to their clock parent is same.     
> and I whether need add this explanation
> 
> in patch commit log description?

Unfortunately I do not understand single thing from this.

Best regards,
Krzysztof