linux-kernel - Re: [PATCH v2 1/2] x86/kexec: Remove unnecessary arch_kexec_kernel_image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAhnKdXbf2fa9Ql8@kernel.org>
Date:   Wed, 8 Mar 2023 11:44:57 +0100
From:   Simon Horman <horms@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Eric Biederman <ebiederm@...ssion.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>, Baoquan He <bhe@...hat.com>,
        x86@...nel.org, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v2 1/2] x86/kexec: Remove unnecessary
 arch_kexec_kernel_image_load()

On Tue, Mar 07, 2023 at 04:44:15PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The x86 implementation of arch_kexec_kernel_image_load() is functionally
> identical to the generic arch_kexec_kernel_image_load():
> 
>   arch_kexec_kernel_image_load                # x86
>     if (!image->fops || !image->fops->load)
>       return ERR_PTR(-ENOEXEC);
>     return image->fops->load(image, image->kernel_buf, ...)
> 
>   arch_kexec_kernel_image_load                # generic
>     kexec_image_load_default
>       if (!image->fops || !image->fops->load)
> 	return ERR_PTR(-ENOEXEC);
>       return image->fops->load(image, image->kernel_buf, ...)
> 
> Remove the x86-specific version and use the generic
> arch_kexec_kernel_image_load().  No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>