[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZAhrT1ICTQjfdeGq@hovoldconsulting.com>
Date: Wed, 8 Mar 2023 12:02:39 +0100
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Lux Aliaga <they@...t.lgbt>, agross@...nel.org,
andersson@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, vkoul@...nel.org,
kishon@...nel.org, alim.akhtar@...sung.com, avri.altman@....com,
bvanassche@....org, keescook@...omium.org, tony.luck@...el.com,
gpiccoli@...lia.com, ~postmarketos/upstreaming@...ts.sr.ht,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
linux-scsi@...r.kernel.org, linux-hardening@...r.kernel.org,
phone-devel@...r.kernel.org, martin.botka@...ainline.org,
marijn.suijten@...ainline.org
Subject: Re: [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support
On Wed, Mar 08, 2023 at 11:09:48AM +0100, Konrad Dybcio wrote:
>
>
> On 6.03.2023 18:08, Lux Aliaga wrote:
> > The SM6125 UFS PHY is compatible with the one from SM6115. Add a
> > compatible for it and modify the config from SM6115 to make them
> > compatible with the SC8280XP binding
> >
> > Signed-off-by: Lux Aliaga <they@...t.lgbt>
> > Reviewed-by: Martin Botka <martin.botka@...ainline.org>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > index 318eea35b972..44c29fdfc551 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> > @@ -620,6 +620,13 @@ static const char * const qmp_phy_vreg_l[] = {
> > "vdda-phy", "vdda-pll",
> > };
> >
> > +static const struct qmp_ufs_offsets qmp_ufs_offsets_v3_660 = {
> > + .serdes = 0,
> > + .pcs = 0xc00,
> > + .tx = 0x400,
> > + .rx = 0x600,
> > +};
> > +
> > static const struct qmp_ufs_offsets qmp_ufs_offsets_v5 = {
> > .serdes = 0,
> > .pcs = 0xc00,
> > @@ -693,6 +700,8 @@ static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
> > static const struct qmp_phy_cfg sm6115_ufsphy_cfg = {
> > .lanes = 1,
> >
> > + .offsets = &qmp_ufs_offsets_v3_660,
> Will this not trigger OOB r/w for the users of qcom,sm6115-smp-ufs-phy
> which specify the regions separately (old binding style)?
No, that should work fine.
But looks like this series needs to be rebased on 6.3-rc1 as these
offsets are now already set in mainline.
Johan
Powered by blists - more mailing lists