linux-kernel - Re: [PATCH v1 06/11] media: starfive: add ISP driver files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <243f92b6-bed7-e1c0-50c6-ab921fa42877@starfivetech.com>
Date:   Wed, 8 Mar 2023 19:04:54 +0800
From:   Jack Zhu <jack.zhu@...rfivetech.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <changhuang.liang@...rfivetech.com>
Subject: Re: [PATCH v1 06/11] media: starfive: add ISP driver files



On 2023/3/8 18:34, Krzysztof Kozlowski wrote:
> On 07/03/2023 10:53, Jack Zhu wrote:
>> 
>> 
>> On 2023/3/3 16:45, Krzysztof Kozlowski wrote:
>>> On 02/03/2023 10:19, jack.zhu wrote:
>>>> Add base driver for Starfive Image Signal Processing Unit which
>>>> handles the data streams from the CSI2 receiver.
>>>>
>>>> Signed-off-by: jack.zhu <jack.zhu@...rfivetech.com>
>>>> ---
>>>>  drivers/media/platform/starfive/stf_isp.c     | 1079 ++++++++++++++
>>>>  drivers/media/platform/starfive/stf_isp.h     |  183 +++
>>>>  .../media/platform/starfive/stf_isp_hw_ops.c  | 1286 +++++++++++++++++
>>>>  3 files changed, 2548 insertions(+)
>>>>  create mode 100644 drivers/media/platform/starfive/stf_isp.c
>>>>  create mode 100644 drivers/media/platform/starfive/stf_isp.h
>>>>  create mode 100644 drivers/media/platform/starfive/stf_isp_hw_ops.c
>>>
>>>
>>>> +}
>>>> +
>>>> +static int stf_isp_reg_read(struct stf_isp_dev *isp_dev, void *arg)
>>>> +{
>>>> +	void __iomem *ispbase = stf_isp_get_ispbase(isp_dev);
>>>> +	struct isp_reg_param *reg_param = arg;
>>>
>>>
>>> Didn't you add now code which does not even build and is not bisectable?
>>>
>> 
>> use patch 11 to build all files in the starfive directory.
>> 
> 
> Not related. So let me put it very simple:
> 
> 1. Does this code build or not?
> 2. Do you certify that code is 100% bisectable?

No, Maybe I need to merge the previous patches[6-11] into one patch to submit?

> 
> 
> Best regards,
> Krzysztof
>