linux-kernel - Re: [PATCH v3 2/3] tty: serial: meson: Add a new compatible string for the G12A SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db540297-2f9b-e420-be33-0a1f1a838862@linaro.org>
Date:   Wed, 8 Mar 2023 13:19:36 +0100
From:   neil.armstrong@...aro.org
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        jirislaby@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, gregkh@...uxfoundation.org,
        Christian Hewitt <christianshewitt@...il.com>
Subject: Re: [PATCH v3 2/3] tty: serial: meson: Add a new compatible string
 for the G12A SoC

On 07/03/2023 23:26, Martin Blumenstingl wrote:
> Amlogic Meson G12A (and later) SoCs also have the "divide XTAL by 2" bit
> as the S4 UART controllers. Add a new compatible string for these SoCs
> and enable the has_xtal_div2 flag for them.
> 
> Tested-by: Christian Hewitt <christianshewitt@...il.com>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
> Changes from v1 -> v2:
> - none
> 
> Changes from v2 -> v3:
> - none
> 
> 
>   drivers/tty/serial/meson_uart.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 74110017988a..2501db5a7aaf 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -779,7 +779,7 @@ static int meson_uart_remove(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static struct meson_uart_data s4_uart_data = {
> +static struct meson_uart_data meson_g12a_uart_data = {
>   	.has_xtal_div2 = true,
>   };
>   
> @@ -788,9 +788,13 @@ static const struct of_device_id meson_uart_dt_match[] = {
>   	{ .compatible = "amlogic,meson8-uart" },
>   	{ .compatible = "amlogic,meson8b-uart" },
>   	{ .compatible = "amlogic,meson-gx-uart" },
> +	{
> +		.compatible = "amlogic,meson-g12a-uart",
> +		.data = (void *)&meson_g12a_uart_data,
> +	},
>   	{
>   		.compatible = "amlogic,meson-s4-uart",
> -		.data = (void *)&s4_uart_data,
> +		.data = (void *)&meson_g12a_uart_data,
>   	},
>   	{ /* sentinel */ },
>   };

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>