[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c4d53e9c-dac0-8ccc-dc86-faada324beba@linaro.org>
Date: Wed, 8 Mar 2023 13:21:44 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Nishanth Menon <nm@...com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Tero Kristo <kristo@...nel.org>,
Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH] dt-bindings: pinctrl: k3: Introduce debounce select mux
macros
On 08/03/2023 09:43, Nishanth Menon wrote:
> Introduce the debounce select mux macros to allow folks to setup
> debounce configuration for pins. Each configuration selected maps
> to a specific timing register as documented in appropriate Technical
> Reference Manual (example:[1]).
>
> [1] AM625x TRM (section 6.1.2.2): https://www.ti.com/lit/pdf/spruiv7
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> include/dt-bindings/pinctrl/k3.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
So these are register values? You should consider moving them out of
bindings, like we do for some other platforms.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists