linux-kernel - Re: [PATCH v2 03/21] of: Rename of_modalias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230308001903.GA513330-robh@kernel.org>
Date:   Tue, 7 Mar 2023 18:19:03 -0600
From:   Rob Herring <robh@...nel.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Walle <michael@...le.cc>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Robert Marko <robert.marko@...tura.hr>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Sebastian Reichel <sre@...nel.org>,
        Wolfram Sang <wsa@...nel.org>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 03/21] of: Rename of_modalias_node()

On Tue, Mar 07, 2023 at 05:53:41PM +0100, Miquel Raynal wrote:
> This helper does not produce a real modalias, but tries to get the
> "product" compatible part of the "vendor,product" compatibles only. It
> is far from creating a purely useful modalias string and does not seem
> to be used like that directly anyway, so let's try to give this helper a
> more meaningful name before moving there a real modalias helper (already
> existing under of/device.c).
> 
> Also update the various documentations to refer to the strings as
> "aliases" rather than "modaliases" which has a real meaning in the Linux
> kernel.
> 
> There is no functional change.
> 
> Cc: Rafael J. Wysocki <rafael@...nel.org>
> Cc: Len Brown <lenb@...nel.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
> Cc: Maxime Ripard <mripard@...nel.org>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Wolfram Sang <wsa@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> ---
>  drivers/acpi/bus.c                |  7 ++++---
>  drivers/gpu/drm/drm_mipi_dsi.c    |  2 +-
>  drivers/hsi/hsi_core.c            |  2 +-

These should not have been using this function. The matching on just the 
product was a relic from I2C and SPI which we don't want to propogate. 
No clue why ACPI needed it...

If you respin or want to fixup while applying, can you add a kerneldoc 
comment to not add new users of the function. Not that anyone will 
follow that... :(

Reviewed-by: Rob Herring <robh@...nel.org>

>  drivers/i2c/busses/i2c-powermac.c |  2 +-
>  drivers/i2c/i2c-core-of.c         |  2 +-
>  drivers/of/base.c                 | 15 ++++++++-------
>  drivers/spi/spi.c                 |  4 ++--
>  include/linux/of.h                |  2 +-
>  8 files changed, 19 insertions(+), 17 deletions(-)