linux-kernel - Re: next: arch/mips/ar7/gpio.c:19:33: error: field 'chip' has incomplete type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 15:00:45 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        linux-next <linux-next@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-mips@...r.kernel.org, lkft-triage@...ts.linaro.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Phil Mathieu-Daudé <philmd@...aro.org>
Subject: Re: next: arch/mips/ar7/gpio.c:19:33: error: field 'chip' has
 incomplete type

On Tue, Mar 07, 2023 at 07:46:26PM +0100, Arnd Bergmann wrote:
> On Tue, Mar 7, 2023, at 18:10, Naresh Kamboju wrote:
> > Following build regression found while building mips ar7_defconfig
> > on Linux next-20230307 tag.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> >
> > Please find the build log and details below.
> >
> > build log:
> > --------
> > arch/mips/ar7/gpio.c:19:33: error: field 'chip' has incomplete type
> >    19 |         struct gpio_chip        chip;
> 
> It sounds like a result of 21d9526d13b5 ("gpiolib: Make the
> legacy <linux/gpio.h> consumer-only"). I haven't tried it,
> but I think this should fix it, unless there is another bug:
> 
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -7,7 +7,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  
>  #include <asm/mach-ar7/ar7.h>

Thank you!
Can you send this as a formal patch?

-- 
With Best Regards,
Andy Shevchenko