linux-kernel - Re: [PATCH] firmware: xilinx: nvmem: zynqmp: make modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c9e15e5-b88b-2fbc-7671-1f93d3ef50c6@linaro.org>
Date:   Wed, 8 Mar 2023 13:08:54 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Nick Alcock <nick.alcock@...cle.com>, michal.simek@...inx.com
Cc:     Michal Simek <michal.simek@....com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] firmware: xilinx: nvmem: zynqmp: make modular



On 08/03/2023 12:27, Nick Alcock wrote:
> This driver has a MODULE_LICENSE but is not tristate so cannot be
> built as a module, unlike all its peers: make it modular to match.
> 
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Michal Simek <michal.simek@....com>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---

Thanks for fixing this,

Applied thanks,

--srini
>   drivers/nvmem/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> How's this?  (This supplants the previous patch, obviously.)
> 
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 6dec38805041b..3b3832f4dfad1 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -368,7 +368,7 @@ config NVMEM_VF610_OCOTP
>   	  be called nvmem-vf610-ocotp.
>   
>   config NVMEM_ZYNQMP
> -	bool "Xilinx ZYNQMP SoC nvmem firmware support"
> +	tristate "Xilinx ZYNQMP SoC nvmem firmware support"
>   	depends on ARCH_ZYNQMP
>   	help
>   	  This is a driver to access hardware related data like