linux-kernel - Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2023 09:35:50 +0800
From:   zhuyinbo <zhuyinbo@...ngson.cn>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     Jianmin Lv <lvjianmin@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>, wanghongliang@...ngson.cn,
        loongson-kernel@...ts.loongnix.cn, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v13 1/2] dt-bindings: clock: add loongson-2 boot clock
 index


在 2023/3/7 下午8:47, Krzysztof Kozlowski 写道:
> On 07/03/2023 12:50, Yinbo Zhu wrote:
>> The Loongson-2 boot clock was used to spi and lio peripheral and
>> this patch was to add boot clock index number.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>> ---
> This is v13? Where is the changelog then?

in fact, this is a new patch(v1),   but another clock driver patch in 
this series had send as v13 and need depend on

this patch so set current patch as v13.

>
>
>>   include/dt-bindings/clock/loongson,ls2k-clk.h | 25 ++++++++++---------
>>   1 file changed, 13 insertions(+), 12 deletions(-)
>>
>> diff --git a/include/dt-bindings/clock/loongson,ls2k-clk.h b/include/dt-bindings/clock/loongson,ls2k-clk.h
>> index db1e27e792ff1..e86804365e506 100644
>> --- a/include/dt-bindings/clock/loongson,ls2k-clk.h
>> +++ b/include/dt-bindings/clock/loongson,ls2k-clk.h
>> @@ -13,17 +13,18 @@
>>   #define LOONGSON2_DC_PLL				3
>>   #define LOONGSON2_PIX0_PLL				4
>>   #define LOONGSON2_PIX1_PLL				5
>> -#define LOONGSON2_NODE_CLK				6
>> -#define LOONGSON2_HDA_CLK				7
>> -#define LOONGSON2_GPU_CLK				8
>> -#define LOONGSON2_DDR_CLK				9
>> -#define LOONGSON2_GMAC_CLK				10
>> -#define LOONGSON2_DC_CLK				11
>> -#define LOONGSON2_APB_CLK				12
>> -#define LOONGSON2_USB_CLK				13
>> -#define LOONGSON2_SATA_CLK				14
>> -#define LOONGSON2_PIX0_CLK				15
>> -#define LOONGSON2_PIX1_CLK				16
>> -#define LOONGSON2_CLK_END				17
>> +#define LOONGSON2_BOOT_CLK				6
> That's an ABI break and commit msg does not explain it.
you meaning is that need add a explanation in commit msg that why

LOONGSON2_BOOT_CLK was added after LOONGSON2_PIX1_PLL and not add it in ending, right?

>
>> +#define LOONGSON2_NODE_CLK				7
>
>
> Best regards,
> Krzysztof