linux-kernel - RE: [PATCH v2] KVM: move KVM_CAP_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS0PR11MB637380AB654417B99D5FD590DCB49@DS0PR11MB6373.namprd11.prod.outlook.com>
Date:   Wed, 8 Mar 2023 13:31:05 +0000
From:   "Wang, Wei W" <wei.w.wang@...el.com>
To:     "Christopherson,, Sean" <seanjc@...gle.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] KVM: move KVM_CAP_DEVICE_CTRL to the generic check

On Thursday, February 2, 2023 7:30 AM, Sean Christopherson wrote:
> On Thu, Dec 29, 2022, Wei Wang wrote:
> > KVM_CAP_DEVICE_CTRL allows userspace to check if the kvm_device
> > framework (e.g. KVM_CREATE_DEVICE) is supported by KVM. Move
> > KVM_CAP_DEVICE_CTRL to the generic check for the two reasons:
> > 1) it already supports arch agnostic usages (i.e. KVM_DEV_TYPE_VFIO).
> > For example, userspace VFIO implementation may needs to create
> > KVM_DEV_TYPE_VFIO on x86, riscv, or arm etc. It is simpler to have it
> > checked at the generic code than at each arch's code.
> > 2) KVM_CREATE_DEVICE has been added to the generic code.
> 
> I think it's worth adding a link to the v1 patch, as that thread provides the
> context for how KVM ended up unconditionally advertising the feature, e.g.
> instead of trying to be more precise.
> 
> Link: https://lore.kernel.org/all/20221215115207.14784-1-
> wei.w.wang@...el.com
> 
> > Signed-off-by: Wei Wang <wei.w.wang@...el.com>
> > ---
> 
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>
Thanks.

Is this patch ready to be merged along with the link or
need me to re-send to have the link added?