linux-kernel - Re: [PATCH v17 RESEND 3/3] docs: leds: Add MT6370 RGB LED pattern document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230308134208.GK9667@google.com>
Date:   Wed, 8 Mar 2023 13:42:08 +0000
From:   Lee Jones <lee@...nel.org>
To:     ChiYuan Huang <cy_huang@...htek.com>
Cc:     ChiaEn Wu <chiaen_wu@...htek.com>, corbet@....net, pavel@....cz,
        matthias.bgg@...il.com, andriy.shevchenko@...ux.intel.com,
        jacek.anaszewski@...il.com,
        angelogioacchino.delregno@...labora.com, linux-doc@...r.kernel.org,
        peterwu.pub@...il.com, linux-leds@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        szunichen@...il.com
Subject: Re: [PATCH v17 RESEND 3/3] docs: leds: Add MT6370 RGB LED pattern
 document

On Tue, 07 Mar 2023, ChiYuan Huang wrote:

> Hi, Lee:
>
>     Some question about the comment.
> On Sun, Mar 05, 2023 at 10:18:24AM +0000, Lee Jones wrote:
> > On Thu, 23 Feb 2023, ChiaEn Wu wrote:
> >
> > > From: ChiYuan Huang <cy_huang@...htek.com>
> > >
> > > Document the MT6370 RGB LED pattern trigger.
> > >
> > > This simply describe how the pattern works, each timing period, and the
> > > pattern diagram for MT6370 RGB LED.
> > >
> > > Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> > > Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>
> > > ---
> > >  Documentation/leds/leds-mt6370-rgb.rst | 64 ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 64 insertions(+)
> > >  create mode 100644 Documentation/leds/leds-mt6370-rgb.rst
> > >
> > > diff --git a/Documentation/leds/leds-mt6370-rgb.rst b/Documentation/leds/leds-mt6370-rgb.rst
> > > new file mode 100644
> > > index 00000000..d1b2e4f
> > > --- /dev/null
> > > +++ b/Documentation/leds/leds-mt6370-rgb.rst
> > > @@ -0,0 +1,64 @@
> > > +.. SPDX-License-Identifier: GPL-2.0
> > > +
> > > +=========================================
> > > +Kernel driver for Mediatek MT6370 RGB LED
> >
> > Are you describing the device or the kernel driver?
> >
> But referring to others, it seems each one also write this as 'Kernel driver'.
> Sorry, I cannot catch the point. Did you mean to modify this description as
> 'The device for MT6370 RGB LED'?

Just because it's been done before, doesn't make it right.

IMHO, this document should describe the device, not the driver.

--
Lee Jones [李琼斯]