linux-kernel - Re: [PATCH] staging: r8188eu: delete driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAiRPbXff1f27HUz@kroah.com>
Date:   Wed, 8 Mar 2023 14:44:29 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        patches@...ts.linux.dev, Martin Kaiser <martin@...ser.cx>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH] staging: r8188eu: delete driver

On Wed, Mar 08, 2023 at 02:26:39PM +0100, Hans de Goede wrote:
> Hi All,
> 
> > Now that the same hardware that the r8188eu driver supported is
> > supported by the real wireless driver rtl8xxxu, the r8188eu driver can
> > be deleted.
> >
> > Also the rtl8xxxu driver supports way more devices, and is a fraction of
> > the overall size, making this a much better overall solution.
> >
> > Thanks to the r8188eu developers and maintainers and reviewers over the
> > years, your work allowed Linux users to use their hardware before the
> > real driver was implemented properly.
> >
> > Reported-by: Hans de Goede <hdegoede@...hat.com>
> > Cc: Martin Kaiser <martin@...ser.cx>
> > Cc: Larry Finger <Larry.Finger@...inger.net>
> > Cc: Phillip Potter <phil@...lpotter.co.uk>
> > Cc: Pavel Skripkin <paskripkin@...il.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Thank you for doing this, I agree that this is the best solution
> moving forward:
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Great!

Also, to verify the "these devices are supported", I compared the list
of module aliases exported by both drivers.  The r8188eu is a tiny
subset of the rtl8xxxu driver, with no devices listed in the r8188eu
that are not in the rtl8xxxu driver.

Attached are the lists of the vendor/product USB ids for each driver as
proof.

thanks,

greg k-h

View attachment "r8188eu.devices" of type "text/plain" (165 bytes)

View attachment "rtl8xxxu.devices" of type "text/plain" (1079 bytes)