linux-kernel - Re: [PATCH] maple_tree: export symbol mas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230308144343.GA16259@lst.de>
Date:   Wed, 8 Mar 2023 15:43:43 +0100
From:   Christoph Hellwig <hch@....de>
To:     Danilo Krummrich <dakr@...hat.com>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, maple-tree@...ts.infradead.org,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()

On Wed, Mar 08, 2023 at 03:34:29PM +0100, Danilo Krummrich wrote:
> On 3/8/23 11:59, Vlastimil Babka wrote:
>> On 3/2/23 02:52, Liam R. Howlett wrote:
>>> Thanks for the patch.  This should indeed be exported.
>>>
>>> Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
>>
>> What uses it? Don't we export only things used by in-kernel modules?
>
> mas_preallocate() is part of the maple tree's 'Advanced API'. All other 
> functions of this API are exported already.
>
> More specifically, e.g. mas_store_prealloc() is exported which doesn't make 
> a lot of sense without mas_preallocate() being available too.
>
> I don't think it is used outside of mm yet, but as a generic tree 
> implementation maple tree is pretty likely to be used in code built as 
> module, e.g. drivers.

If anyone wants to use they can add the export as needed.