linux-kernel - Re: [PATCH v16 05/13] tty, proc, kernfs, random: Use direct_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAifhy2knWeM2btd@kroah.com>
Date:   Wed, 8 Mar 2023 15:45:27 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@...radead.org>,
        Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.cz>,
        Jeff Layton <jlayton@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Hillf Danton <hdanton@...a.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Christoph Hellwig <hch@....de>,
        John Hubbard <jhubbard@...dia.com>,
        Miklos Szeredi <miklos@...redi.hu>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v16 05/13] tty, proc, kernfs, random: Use
 direct_splice_read()

On Wed, Mar 08, 2023 at 02:37:46PM +0000, David Howells wrote:
> Use direct_splice_read() for tty, procfs, kernfs and random files rather
> than going through generic_file_splice_read() as they just copy the file
> into the output buffer and don't splice pages.  This avoids the need for
> them to have a ->read_folio() to satisfy filemap_splice_read().
> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Christoph Hellwig <hch@....de>
> cc: Jens Axboe <axboe@...nel.dk>
> cc: Al Viro <viro@...iv.linux.org.uk>
> cc: John Hubbard <jhubbard@...dia.com>
> cc: David Hildenbrand <david@...hat.com>
> cc: Matthew Wilcox <willy@...radead.org>
> cc: Miklos Szeredi <miklos@...redi.hu>
> cc: Arnd Bergmann <arnd@...db.de>
> cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> cc: linux-block@...r.kernel.org
> cc: linux-fsdevel@...r.kernel.org
> cc: linux-mm@...ck.org

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>