linux-kernel - Re: [RESEND PATCH v2] sched/debug: Put sched/domains files under the verbose flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAnw3aKvR/9i9kkU@kroah.com>
Date:   Thu, 9 Mar 2023 15:44:45 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Phil Auld <pauld@...hat.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, ritesh.list@...il.com,
        srikar@...ux.vnet.ibm.com, sshegde@...ux.ibm.com,
        vincent.guittot@...aro.org, vishalc@...ux.vnet.ibm.com,
        vschneid@...hat.com
Subject: Re: [RESEND PATCH v2] sched/debug: Put sched/domains files under the
 verbose flag

On Fri, Mar 03, 2023 at 01:37:54PM -0500, Phil Auld wrote:
> The debug files under sched/domains can take a long time to regenerate,
> especially when updates are done one at a time. Move these files under
> the sched verbose debug flag. Allow changes to verbose to trigger
> generation of the files. This lets a user batch the updates but still
> have the information available.  The detailed topology printk messages
> are also under verbose.
> 
> Discussion that lead to this approach can be found in the link below.
> 
> Simplified code to maintain use of debugfs bool routines suggested by
> Michael Ellerman <mpe@...erman.id.au>.
> 
> Signed-off-by: Phil Auld <pauld@...hat.com>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Reviewed-by: Valentin Schneider <vschneid@...hat.com>
> Reviewed-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> Tested-by: Vishal Chourasia <vishalc@...ux.vnet.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Vishal Chourasia <vishalc@...ux.vnet.ibm.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@li-05afa54c-330e-11b2-a85c-e3f3aa0db1e9.ibm.com/
> ---
> 
>  v2: fix comment typo and use cpumask_empty()
> 
>  kernel/sched/debug.c | 52 +++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 49 insertions(+), 3 deletions(-)

As no one has picked this up yet, and it is really a debugfs issue, I'll
queue this up in the driver-core tree (which takes debugfs changes) for
6.4-rc1 unless someone screams.

thanks,

greg k-h