linux-kernel - Re: [PATCH v4] scsi: ufs: core: Add trace event for MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99f2ea8e-e543-fc14-91d7-0e7e29d2f381@acm.org>
Date:   Thu, 9 Mar 2023 07:45:56 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Ziqi Chen <quic_ziqichen@...cinc.com>, quic_asutoshd@...cinc.com,
        quic_cang@...cinc.com, mani@...nel.org, stanley.chu@...iatek.com,
        adrian.hunter@...el.com, beanhuo@...ron.com, avri.altman@....com,
        junwoo80.lee@...sung.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: core: Add trace event for MCQ

On 3/8/23 18:44, Ziqi Chen wrote:
> Thanks for you suggestion. But the member hwq->id is an Unsigned 
> integer. if you want to identify SDB mode and MCQ mode,  using "0" is 
> enough, Or how about add string such as below?
> 
> ufshcd_command: MCQ: complete_rsp: 1d84000.ufshc: tag: 14, DB: 0x0, 
> size: 32768, IS: 0, LBA: 5979448,opcode: 0x2a (WRITE_10),group_id: 0x0, 
> hqid: 2

Hi Ziqi,

Since 0 is a valid queue ID using 0 to identify the legacy command 
submission mechanism is ambiguous.

Thanks,

Bart.