linux-kernel - Re: [PATCH net] net: ravb: Fix possible UAF bug in ravb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9054b170-8ed2-445c-6150-82f98af5808b@omp.ru>
Date:   Thu, 9 Mar 2023 18:47:27 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Zheng Wang <zyytlz.wz@....com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hackerzheng666@...il.com>,
        <1395428693sheep@...il.com>, <alex000young@...il.com>
Subject: Re: [PATCH net] net: ravb: Fix possible UAF bug in ravb_remove

Hello!

On 3/9/23 1:02 PM, Zheng Wang wrote:

> In ravb_probe, priv->work was bound with ravb_tx_timeout_work.
> If timeout occurs, it will start the work. And if we call
> ravb_remove without finishing the work, ther may be a use
> after free bug on ndev.

   Have you actually encountered it?

> Fix it by finishing the job before cleanup in ravb_remove.
> 
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")

   Hm... sorry about that. :-)

> Signed-off-by: Zheng Wang <zyytlz.wz@....com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 0f54849a3823..07a08e72f440 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -2892,6 +2892,7 @@ static int ravb_remove(struct platform_device *pdev)
>  	struct ravb_private *priv = netdev_priv(ndev);
>  	const struct ravb_hw_info *info = priv->info;
>  
> +	cancel_work_sync(&priv->work);

   I think we need an empty line here...

>  	/* Stop PTP Clock driver */
>  	if (info->ccc_gac)
>  		ravb_ptp_stop(ndev);

MBR, Sergey