linux-kernel - [PATCH v2 063/101] fbdev/pvr2fb: Duplicate video-mode option string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230309160201.5163-64-tzimmermann@suse.de>
Date:   Thu,  9 Mar 2023 17:01:23 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     deller@....de, geert+renesas@...der.be, timur@...nel.org,
        rdunlap@...radead.org, paulus@...ba.org, benh@...nel.crashing.org,
        linux@...linux.org.uk, pjones@...hat.com, adaplas@...il.com,
        s.hauer@...gutronix.de, shawnguo@...nel.org, mbroemme@...mpq.org,
        thomas@...ischhofer.net, James.Bottomley@...senPartnership.com,
        sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        corbet@....net
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>
Subject: [PATCH v2 063/101] fbdev/pvr2fb: Duplicate video-mode option string

Assume that the driver does not own the option string or its substrings
and hence duplicate the option string for the video mode. Allocate the
copy's memory with kstrdup() and free it in the module's exit function,
as well as the init function's error handling.

Done in preparation of switching the driver to struct option_iter and
constifying the option string.

v2:
	* replace static memory with kstrdup()/kfree() (Geert)

Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
---
 drivers/video/fbdev/pvr2fb.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 6888127a5eb8..f6be2649840d 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -225,6 +225,7 @@ static struct fb_videomode pvr2_modedb[] = {
 #define DEFMODE_VGA	2
 
 static int defmode = DEFMODE_NTSC;
+static char *mode_option_buf;
 static char *mode_option = NULL;
 
 static inline void pvr2fb_set_pal_type(unsigned int type)
@@ -1049,7 +1050,9 @@ static int __init pvr2fb_setup(char *options)
 		} else if (!strncmp(this_opt, "nowrap", 6)) {
 			nowrap = 1;
 		} else {
-			mode_option = this_opt;
+			kfree(mode_option_buf);
+			mode_option_buf = kstrdup(this_opt, GFP_KERNEL); // ignore errors
+			mode_option = mode_option_buf;
 		}
 	}
 
@@ -1094,8 +1097,11 @@ static int __init pvr2fb_init(void)
 #endif
 
 	fb_info = framebuffer_alloc(sizeof(struct pvr2fb_par), NULL);
-	if (!fb_info)
+	if (!fb_info) {
+		kfree(mode_option_buf);
+		mode_option_buf = NULL;
 		return -ENOMEM;
+	}
 
 	currentpar = fb_info->par;
 
@@ -1111,6 +1117,8 @@ static int __init pvr2fb_init(void)
 			printk(KERN_ERR "pvr2fb: Failed init of %s device\n",
 				pvr_board->name);
 			framebuffer_release(fb_info);
+			kfree(mode_option_buf);
+			mode_option_buf = NULL;
 			break;
 		}
 	}
@@ -1135,6 +1143,7 @@ static void __exit pvr2fb_exit(void)
 
 	unregister_framebuffer(fb_info);
 	framebuffer_release(fb_info);
+	kfree(mode_option_buf);
 }
 
 module_init(pvr2fb_init);
-- 
2.39.2