linux-kernel - Re: [PATCH] nfc: pn533: initialize struct pn533_out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAoMOJFi9uXhEveK@corigine.com>
Date:   Thu, 9 Mar 2023 17:41:28 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Minsuk Kang <linuxlovemin@...sei.ac.kr>,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org,
        syzbot+1e608ba4217c96d1952f@...kaller.appspotmail.com
Subject: Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly

On Thu, Mar 09, 2023 at 07:10:25PM +0300, Fedor Pchelkin wrote:
> On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote:
> > 
> > nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> >      It's probably not worth respinning, but I expect the preferred
> >      approach is (*completely untested!*)
> > 
> > 	...
> > 	struct pn533_out_arg arg;
> > 	...
> > 
> > 	arg.phy = phy;
> > 
> 
> That is much prettier, thanks for advice!
> 
> BTW, is reverse xmas tree ordering considered to be a general
> recommendation for all new kernel patches?

I think that the situation is that some subsystem maintainers require it,
while other's do not. So no.