[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4814c9d9-d79b-4634-bfe0-01d05c727ac9@linux.ibm.com>
Date: Thu, 9 Mar 2023 13:36:36 -0500
From: Matthew Rosato <mjrosato@...ux.ibm.com>
To: Niklas Schnelle <schnelle@...ux.ibm.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lukas Wunner <lukas@...ner.de>
Cc: Gerd Bayer <gbayer@...ux.ibm.com>, linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 2/4] s390/pci: only add specific device in
zpci_bus_scan_device()
On 3/6/23 10:10 AM, Niklas Schnelle wrote:
> As the name suggests zpci_bus_scan_device() is used to scan a specific
> device and thus pci_bus_add_device() for that device is sufficient.
> Furthermore move this call inside the rescan/remove locking.
>
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
I think a suggested by tag from Bjorn is appropriate here
Otherwise:
Reviewed-by: Matthew Rosato <mjrosato@...ux.ibm.com>
> ---
> arch/s390/pci/pci_bus.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/pci/pci_bus.c b/arch/s390/pci/pci_bus.c
> index a99926af2b69..ae46c280b35f 100644
> --- a/arch/s390/pci/pci_bus.c
> +++ b/arch/s390/pci/pci_bus.c
> @@ -85,9 +85,8 @@ int zpci_bus_scan_device(struct zpci_dev *zdev)
> if (!pdev)
> return -ENODEV;
>
> - pci_bus_add_device(pdev);
> pci_lock_rescan_remove();
> - pci_bus_add_devices(zdev->zbus->bus);
> + pci_bus_add_device(pdev);
> pci_unlock_rescan_remove();
>
> return 0;
Powered by blists - more mailing lists