linux-kernel - Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Mar 2023 13:03:36 -0600
From:   Steev Klimaszewski <steev@...i.org>
To:     Johan Hovold <johan+linaro@...nel.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guru Das Srinagesh <quic_gurus@...cinc.com>,
        Sibi Sankar <quic_sibis@...cinc.com>
Subject: Re: [PATCH] firmware: qcom: scm: fix bogus irq error at probe

On Thu, Mar 9, 2023 at 5:16 AM Johan Hovold <johan+linaro@...nel.org> wrote:
>
> A recent commit added support for an optional interrupt which is only
> available on some platforms.
>
> Stop spamming the logs with bogus error messages on platforms that do
> not use this new optional resource:
>
>         qcom_scm firmware:scm: error -ENXIO: IRQ index 0 not found
>
> Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
> Cc: Guru Das Srinagesh <quic_gurus@...cinc.com>
> Cc: Sibi Sankar <quic_sibis@...cinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>  drivers/firmware/qcom_scm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 468d4d5ab550..b1e11f85b805 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1479,7 +1479,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
>
>         init_completion(&__scm->waitq_comp);
>
> -       irq = platform_get_irq(pdev, 0);
> +       irq = platform_get_irq_optional(pdev, 0);
>         if (irq < 0) {
>                 if (irq != -ENXIO)
>                         return irq;
> --
> 2.39.2
>

Thank you!
Tested on the Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@...i.org> # Thinkpad X13s