linux-kernel - Re: [PATCH v4 6/8] mm: vmscan: hold write lock to reparent shrinker nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c245ab8e-8801-a202-76f1-72965effe09a@ya.ru>
Date:   Thu, 9 Mar 2023 22:32:46 +0300
From:   Kirill Tkhai <tkhai@...ru>
To:     Qi Zheng <zhengqi.arch@...edance.com>, akpm@...ux-foundation.org,
        hannes@...xchg.org, shakeelb@...gle.com, mhocko@...nel.org,
        roman.gushchin@...ux.dev, muchun.song@...ux.dev, david@...hat.com,
        shy828301@...il.com, rppt@...nel.org
Cc:     sultan@...neltoast.com, dave@...olabs.net,
        penguin-kernel@...ove.SAKURA.ne.jp, paulmck@...nel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/8] mm: vmscan: hold write lock to reparent shrinker
 nr_deferred

On 07.03.2023 09:56, Qi Zheng wrote:
> For now, reparent_shrinker_deferred() is the only holder
> of read lock of shrinker_rwsem. And it already holds the
> global cgroup_mutex, so it will not be called in parallel.
> 
> Therefore, in order to convert shrinker_rwsem to shrinker_mutex
> later, here we change to hold the write lock of shrinker_rwsem
> to reparent.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Acked-by: Kirill Tkhai <tkhai@...ru>

> ---
>  mm/vmscan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 9a5a3da5c8b5..7aaf6f94ac1b 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -451,7 +451,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg)
>  		parent = root_mem_cgroup;
>  
>  	/* Prevent from concurrent shrinker_info expand */
> -	down_read(&shrinker_rwsem);
> +	down_write(&shrinker_rwsem);
>  	for_each_node(nid) {
>  		child_info = shrinker_info_protected(memcg, nid);
>  		parent_info = shrinker_info_protected(parent, nid);
> @@ -460,7 +460,7 @@ void reparent_shrinker_deferred(struct mem_cgroup *memcg)
>  			atomic_long_add(nr, &parent_info->nr_deferred[i]);
>  		}
>  	}
> -	up_read(&shrinker_rwsem);
> +	up_write(&shrinker_rwsem);
>  }
>  
>  static bool cgroup_reclaim(struct scan_control *sc)