linux-kernel - Re: [PATCH v3 2/2] dyndbg: use the module notifier callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZApIk1aY/OnDfpOM@bombadil.infradead.org>
Date:   Thu, 9 Mar 2023 12:58:59 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Vincenzo Palazzo <vincenzopalazzodev@...il.com>
Cc:     Jason Baron <jbaron@...mai.com>, jim.cromie@...il.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-modules@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v3 2/2] dyndbg: use the module notifier callbacks

On Mon, Mar 06, 2023 at 06:57:17PM +0100, Vincenzo Palazzo wrote:
> > Bring dynamic debug in line with other subsystems by using the module
> > notifier callbacks. This results in a net decrease in core module
> > code.
> >
> > Additionally, Jim Cromie has a new dynamic debug classmap feature,
> > which requires that jump labels be initialized prior to dynamic debug.
> > Specifically, the new feature toggles a jump label from the existing
> > dynamic_debug_setup() function. However, this does not currently work
> > properly, because jump labels are initialized via the
> > 'module_notify_list' notifier chain, which is invoked after the
> > current call to dynamic_debug_setup(). Thus, this patch ensures that
> > jump labels are initialized prior to dynamic debug by setting the
> > dynamic debug notifier priority to 0, while jump labels have the
> > higher priority of 1.
> >
> > Tested by Jim using his new test case, and I've verfied the correct
> > printing via: # modprobe test_dynamic_debug dyndbg.
> >
> > Link: https://lore.kernel.org/lkml/20230113193016.749791-21-jim.cromie@gmail.com/
> > Reported-by: kernel test robot <lkp@...el.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202302190427.9iIK2NfJ-lkp@intel.com/
> > Tested-by: Jim Cromie <jim.cromie@...il.com>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > CC: Jim Cromie <jim.cromie@...il.com>
> > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Jason Baron <jbaron@...mai.com>
> 
> Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@...il.com>

Tag applied too thanks.

  Luis