linux-kernel - Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac6ba9c-4230-aff7-c93d-23eaf6895464@linaro.org>
Date:   Thu, 9 Mar 2023 23:37:17 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Jianhua Lu <lujianhua000@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523


[...]
= of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
>>>>> +		if (!dsi1) {
>>>>> +			dev_err(dev, "cannot get secondary DSI node.\n");
>>>>> +			return -ENODEV;
>>>>> +		}
>>>>> +
>>>>> +		dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
>>>>> +		of_node_put(dsi1);
>>>> Shouldn't you put the reference only if it's found?
>>> thanks for spot it.
Apparently not.. please don't change this

Konrad
>>>>
>>>>> +		if (!dsi1_host) {
>>>>> +			dev_err(dev, "cannot get secondary DSI host\n");
>>>>> +			return -EPROBE_DEFER;
>>>> dev_err_probe, here and in neighbouring exit return paths?
>>> Acked.
>>>>
>>>>
>>>> Konrad