linux-kernel - Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back firmware-name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bce148d7-7e22-dda7-820d-5d940f313add@linaro.org>
Date:   Thu, 9 Mar 2023 07:27:16 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: bring back
 firmware-name

On 08/03/2023 23:48, Rob Herring wrote:
> On Sun, Mar 05, 2023 at 01:59:17PM +0100, Krzysztof Kozlowski wrote:
>> The firmware-name property was moved from common qcom,pas-common.yaml
>> binding to each device-specific schema, but the qcom,adsp.yaml was not
>> updated.
>>
>> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> index 643ee787a81f..828dfebaef6a 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
>> @@ -44,6 +44,10 @@ properties:
>>      maxItems: 1
>>      description: Reference to the reserved-memory for the Hexagon core
>>  
>> +  firmware-name:
>> +    $ref: /schemas/types.yaml#/definitions/string
> 
> We need to stop redefining the type for 'firmware-name'. I'm adding it 
> to dtschema, so here just put 'maxItems: 1'. 

Oh, yes! But maybe we should add string pattern to "-name" in general?
Just like we have for "-names"?



Best regards,
Krzysztof