| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1583219b-61ad-ba57-470e-0a8202cbe277@linaro.org>
Date: Thu, 9 Mar 2023 10:36:59 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Maximilian Luz <luzmaximilian@...il.com>,
Bjorn Andersson <andersson@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Ard Biesheuvel <ardb@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Johan Hovold <johan@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
Ilias Apalodimas <ilias.apalodimas@...aro.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Sumit Garg <sumit.garg@...aro.org>,
Steev Klimaszewski <steev@...i.org>,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] firmware: Add support for Qualcomm UEFI Secure
Application
On 08/03/2023 17:02, Maximilian Luz wrote:
> On 3/7/23 16:51, Dmitry Baryshkov wrote:
>> On 05/03/2023 04:21, Maximilian Luz wrote:
>>> On platforms using the Qualcomm UEFI Secure Application (uefisecapp),
>>> EFI variables cannot be accessed via the standard interface in EFI
>>> runtime mode. The respective functions return EFI_UNSUPPORTED. On these
>>> platforms, we instead need to talk to uefisecapp. This commit provides
>>> support for this and registers the respective efivars operations to
>>> access EFI variables from the kernel.
>>>
>>> Communication with uefisecapp follows the Qualcomm QSEECOM / Secure OS
>>> conventions via the respective SCM call interface. This is also the
>>> reason why variable access works normally while boot services are
>>> active. During this time, said SCM interface is managed by the boot
>>> services. When calling ExitBootServices(), the ownership is transferred
>>> to the kernel. Therefore, UEFI must not use that interface itself (as
>>> multiple parties accessing this interface at the same time may lead to
>>> complications) and cannot access variables for us.
>>>
>>> Signed-off-by: Maximilian Luz <luzmaximilian@...il.com>
>>> ---
>>>
>>> Changes in v3:
>>> - No functional changes.
>>>
>>> Changes in v2:
>>> - Rename (qctree -> qseecom) to allow differentiation between old
>>> (qseecom) and new (smcinvoke) interfaces to the trusted execution
>>> environment.
>>>
>>> ---
>>> MAINTAINERS | 6 +
>>> drivers/firmware/Kconfig | 16 +
>>> drivers/firmware/Makefile | 1 +
>>> drivers/firmware/qcom_qseecom.c | 11 +-
>>> drivers/firmware/qcom_qseecom_uefisecapp.c | 746 +++++++++++++++++++++
>>> 5 files changed, 779 insertions(+), 1 deletion(-)
>>> create mode 100644 drivers/firmware/qcom_qseecom_uefisecapp.c
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index ef1f806986e9..35d614de6bbc 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -17371,6 +17371,12 @@ S: Maintained
>>> F: Documentation/devicetree/bindings/mtd/qcom,nandc.yaml
>>> F: drivers/mtd/nand/raw/qcom_nandc.c
>>> +QUALCOMM QSEECOM UEFISECAPP DRIVER
>>> +M: Maximilian Luz <luzmaximilian@...il.com>
>>> +L: linux-arm-msm@...r.kernel.org
>>> +S: Maintained
>>> +F: drivers/firmware/qcom_qseecom_uefisecapp.c
>>> +
>>> QUALCOMM RMNET DRIVER
>>> M: Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>
>>> M: Sean Tranchetti <quic_stranche@...cinc.com>
>>> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>>> index 22eec0835abf..b9ad753a195b 100644
>>> --- a/drivers/firmware/Kconfig
>>> +++ b/drivers/firmware/Kconfig
>>> @@ -241,6 +241,22 @@ config QCOM_QSEECOM
>>> Select M or Y here to enable the QSEECOM interface driver.
>>> +config QCOM_QSEECOM_UEFISECAPP
>>> + tristate "Qualcomm SEE UEFI Secure App client driver"
>>> + depends on QCOM_QSEECOM
>>> + depends on EFI
>>> + help
>>> + Various Qualcomm SoCs do not allow direct access to EFI
>>> variables.
>>> + Instead, these need to be accessed via the UEFI Secure
>>> Application
>>> + (uefisecapp), residing in the Secure Execution Environment (SEE).
>>> +
>>> + This module provides a client driver for uefisecapp,
>>> installing efivar
>>> + operations to allow the kernel accessing EFI variables, and
>>> via that also
>>> + provide user-space with access to EFI variables via efivarfs.
>>> +
>>> + Select M or Y here to provide access to EFI variables on the
>>> + aforementioned platforms.
>>> +
>>> config SYSFB
>>> bool
>>> select BOOT_VESA_SUPPORT
>>> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
>>> index aa48e0821b7d..d41b094a5e58 100644
>>> --- a/drivers/firmware/Makefile
>>> +++ b/drivers/firmware/Makefile
>>> @@ -21,6 +21,7 @@ obj-$(CONFIG_FW_CFG_SYSFS) += qemu_fw_cfg.o
>>> obj-$(CONFIG_QCOM_SCM) += qcom-scm.o
>>> qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o
>>> obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o
>>> +obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o
>>> obj-$(CONFIG_SYSFB) += sysfb.o
>>> obj-$(CONFIG_SYSFB_SIMPLEFB) += sysfb_simplefb.o
>>> obj-$(CONFIG_TI_SCI_PROTOCOL) += ti_sci.o
>>> diff --git a/drivers/firmware/qcom_qseecom.c
>>> b/drivers/firmware/qcom_qseecom.c
>>> index efa5b115b2f1..ae42341dce1c 100644
>>> --- a/drivers/firmware/qcom_qseecom.c
>>> +++ b/drivers/firmware/qcom_qseecom.c
>>> @@ -216,8 +216,17 @@ struct qseecom_data {
>>> int num_cells;
>>> };
>>> +static const struct mfd_cell qseecom_cells_sc8280xp[] = {
>>> + { .name = "qcom_qseecom_uefisecapp", },
>>> +};
>>> +
>>> +static const struct qseecom_data qseecom_data_sc8280xp = {
>>> + .cells = qseecom_cells_sc8280xp,
>>> + .num_cells = ARRAY_SIZE(qseecom_cells_sc8280xp),
>>> +};
>>> +
>>> static const struct of_device_id qseecom_dt_match[] = {
>>> - { .compatible = "qcom,qseecom-sc8280xp", },
>>> + { .compatible = "qcom,qseecom-sc8280xp", .data =
>>> &qseecom_data_sc8280xp },
>>
>> Note: the SoC doesn't fully describe the list of avialble qseecom
>> applications. It depends on the particular vendor enabling or
>> disabling them. It might be better to turn qseecom into the bus,
>> create a list of possible app names and use qseecom_app_get_id() to
>> check whether the application is available or not. Then you can
>> instantiate only available devices and provide the app_id via struct
>> qseecom_app_device wrapping struct device:
>
> Alright, so would we have a SoC specific list of apps that we then check
> or a
> global one?
Good question. Especially given that additional applications can be
loaded on demand. I'd say, let's go for the global list for now. If
necessary we can customize that further basing on the SoC compatibles.
>
> As I've elaborated on a previous version: I'm a bit wary of using
> qseecom_app_get_id() in this way, since the Windows driver I've got this
> from
> expects the app to be present when calling that function. So I don't
> know much
> about the failure cases, especially when it isn't present.
>
> At this point, I'm just assuming that "res.status !=
> QSEECOM_RESULT_SUCCESS"
> means the app isn't present, but I don't know whether this can fail in
> other
> ways. For a proper detection system I'd prefer if we can differentiate
> between
> "some internal failure" and "not-present" cases.
Please take a look at
https://git.codelinaro.org/clo/la/kernel/msm-5.10/-/blob/KERNEL.PLATFORM.1.0.r1-13000-kernel.0/drivers/misc/qseecom.c#L2683
Note, the driver supports loading and unloading applications, we can
ignore that for now.
>
> I can still give that a try thouhg.
>
> Maybe you or someone else knows a bit more about that than I do and can
> set my
> mind at ease? (Again, all my knowledge about this comes from reverse
> engineering, so it's not that much.)
>
>> struct qseecom_app_device {
>> struct device dev;
>> u32 app_id;
>> };
>>
>>> { .compatible = "qcom,qseecom", },
>>> { }
>>> };
>>> diff --git a/drivers/firmware/qcom_qseecom_uefisecapp.c
>>> b/drivers/firmware/qcom_qseecom_uefisecapp.c
>>> new file mode 100644
>>> index 000000000000..8d772fe1f589
>>> --- /dev/null
>>> +++ b/drivers/firmware/qcom_qseecom_uefisecapp.c
>>> @@ -0,0 +1,746 @@
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>> +/*
>>> + * Client driver for Qualcomm UEFI Secure Application
>>> (qcom.tz.uefisecapp).
>>> + * Provides access to UEFI variables on platforms where they are
>>> secured by the
>>> + * aforementioned Secure Execution Environment (SEE) application.
>>> + *
>>> + * Copyright (C) 2023 Maximilian Luz <luzmaximilian@...il.com>
>>> + */
>>> +
>>> +#include <linux/efi.h>
>>> +#include <linux/firmware/qcom/qcom_qseecom.h>
>>> +#include <linux/kernel.h>
>>> +#include <linux/module.h>
>>> +#include <linux/mutex.h>
>>> +#include <linux/of.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/types.h>
>>> +
>>> +
>>> +/* -- UTF-16 helpers.
>>> ------------------------------------------------------- */
>>> +
>>> +static unsigned long utf16_strnlen(const efi_char16_t *str, unsigned
>>> long max)
>>> +{
>>> + size_t i;
>>> +
>>> + for (i = 0; *str != 0 && i < max; i++, str++) {
>>> + /* Do nothing, all is handled in the for statement. */
>>> + }
>>> +
>>> + return i;
>>> +}
>>> +
>>> +/**
>>> + * utf16_strsize() - Compute the number of bytes required to store a
>>> + * null-terminated UTF-16 string.
>>> + * @str: The string to compute the size for.
>>> + *
>>> + * Return: Returns the minimum number of bytes required to store the
>>> given
>>> + * null-terminated string, including its null-terminator.
>>> + */
>>> +static unsigned long utf16_strsize(const efi_char16_t *str)
>>> +{
>>> + return (utf16_strnlen(str, U32_MAX) + 1) * sizeof(str[0]);
>>> +}
>>> +
>>> +static unsigned long utf16_strlcpy(efi_char16_t *dst, const
>>> efi_char16_t *src, unsigned long size)
>>> +{
>>> + unsigned long actual = utf16_strnlen(src, size - 1);
>>> +
>>> + memcpy(dst, src, actual * sizeof(src[0]));
>>> + dst[actual] = 0;
>>> +
>>> + return actual;
>>> +}
>>> +
>>> +/**
>>> + * utf16_copy_to_buf() - Copy the given UTF-16 string to a buffer.
>>> + * @dst: Pointer to the output buffer
>>> + * @src: Pointer to the null-terminated UTF-16 string to be copied.
>>> + * @bytes: Maximum number of bytes to copy.
>>> + *
>>> + * Copies the given string to the given buffer, ensuring that the
>>> output buffer
>>> + * is not overrun and that the string in the output buffer will
>>> always be
>>> + * null-terminated.
>>> + *
>>> + * Return: Returns the length of the copied string, without
>>> null-terminator.
>>> + */
>>> +static unsigned long utf16_copy_to_buf(efi_char16_t *dst, const
>>> efi_char16_t *src,
>>> + unsigned long bytes)
>>> +{
>>> + return utf16_strlcpy(dst, src, bytes / sizeof(src[0]));
>>> +}
>>
>> These functions seem generic enough, please move them to
>> lib/ucs2_string.c. Use the existing functions if they suit.
>
> Right, will do. Not sure how I missed those when looking for utf16
> string functions...
>
>>> +
>>> +
>>
>> Double empty lines
>>
>>> +/* -- Qualcomm "uefisecapp" interface definitions.
>>> -------------------------- */
>>> +
>>> +#define QSEE_UEFISEC_APP_NAME "qcom.tz.uefisecapp"
>>> +
>>> +#define QSEE_CMD_UEFI(x) (0x8000 | (x))
>>> +#define QSEE_CMD_UEFI_GET_VARIABLE QSEE_CMD_UEFI(0)
>>> +#define QSEE_CMD_UEFI_SET_VARIABLE QSEE_CMD_UEFI(1)
>>> +#define QSEE_CMD_UEFI_GET_NEXT_VARIABLE QSEE_CMD_UEFI(2)
>>> +#define QSEE_CMD_UEFI_QUERY_VARIABLE_INFO QSEE_CMD_UEFI(3)
>>> +
>>> +/**
>>> + * struct qsee_req_uefi_get_variable - Request for GetVariable command.
>>> + * @command_id: The ID of the command. Must be
>>> %QSEE_CMD_UEFI_GET_VARIABLE.
>>> + * @length: Length of the request in bytes, including this
>>> struct and any
>>> + * parameters (name, GUID) stored after it as well as
>>> any padding
>>> + * thereof for alignment.
>>> + * @name_offset: Offset from the start of this struct to where the
>>> variable
>>> + * name is stored (as utf-16 string), in bytes.
>>> + * @name_size: Size of the name parameter in bytes, including
>>> null-terminator.
>>> + * @guid_offset: Offset from the start of this struct to where the GUID
>>> + * parameter is stored, in bytes.
>>> + * @guid_size: Size of the GUID parameter in bytes, i.e.
>>> sizeof(efi_guid_t).
>>> + * @data_size: Size of the output buffer, in bytes.
>>> + */
>>> +struct qsee_req_uefi_get_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 name_offset;
>>> + u32 name_size;
>>> + u32 guid_offset;
>>> + u32 guid_size;
>>> + u32 data_size;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_rsp_uefi_get_variable - Response for GetVariable
>>> command.
>>> + * @command_id: The ID of the command. Should be
>>> %QSEE_CMD_UEFI_GET_VARIABLE.
>>> + * @length: Length of the response in bytes, including this
>>> struct and the
>>> + * returned data.
>>> + * @status: Status of this command.
>>> + * @attributes: EFI variable attributes.
>>> + * @data_offset: Offset from the start of this struct to where the
>>> data is
>>> + * stored, in bytes.
>>> + * @data_size: Size of the returned data, in bytes. In case status
>>> indicates
>>> + * that the buffer is too small, this will be the size
>>> required
>>> + * to store the EFI variable data.
>>> + */
>>> +struct qsee_rsp_uefi_get_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 status;
>>> + u32 attributes;
>>> + u32 data_offset;
>>> + u32 data_size;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_req_uefi_set_variable - Request for the SetVariable
>>> command.
>>> + * @command_id: The ID of the command. Must be
>>> %QSEE_CMD_UEFI_SET_VARIABLE.
>>> + * @length: Length of the request in bytes, including this
>>> struct and any
>>> + * parameters (name, GUID, data) stored after it as
>>> well as any
>>> + * padding thereof required for alignment.
>>> + * @name_offset: Offset from the start of this struct to where the
>>> variable
>>> + * name is stored (as utf-16 string), in bytes.
>>> + * @name_size: Size of the name parameter in bytes, including
>>> null-terminator.
>>> + * @guid_offset: Offset from the start of this struct to where the GUID
>>> + * parameter is stored, in bytes.
>>> + * @guid_size: Size of the GUID parameter in bytes, i.e.
>>> sizeof(efi_guid_t).
>>> + * @attributes: The EFI variable attributes to set for this variable.
>>> + * @data_offset: Offset from the start of this struct to where the
>>> EFI variable
>>> + * data is stored, in bytes.
>>> + * @data_size: Size of EFI variable data, in bytes.
>>> + *
>>> + */
>>> +struct qsee_req_uefi_set_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 name_offset;
>>> + u32 name_size;
>>> + u32 guid_offset;
>>> + u32 guid_size;
>>> + u32 attributes;
>>> + u32 data_offset;
>>> + u32 data_size;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_rsp_uefi_set_variable - Response for the SetVariable
>>> command.
>>> + * @command_id: The ID of the command. Should be
>>> %QSEE_CMD_UEFI_SET_VARIABLE.
>>> + * @length: The length of this response, i.e. the size of this
>>> struct in
>>> + * bytes.
>>> + * @status: Status of this command.
>>> + * @_unknown1: Unknown response field.
>>> + * @_unknown2: Unknown response field.
>>> + */
>>> +struct qsee_rsp_uefi_set_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 status;
>>> + u32 _unknown1;
>>> + u32 _unknown2;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_req_uefi_get_next_variable - Request for the
>>> + * GetNextVariableName command.
>>> + * @command_id: The ID of the command. Must be
>>> + * %QSEE_CMD_UEFI_GET_NEXT_VARIABLE.
>>> + * @length: Length of the request in bytes, including this
>>> struct and any
>>> + * parameters (name, GUID) stored after it as well as
>>> any padding
>>> + * thereof for alignment.
>>> + * @guid_offset: Offset from the start of this struct to where the GUID
>>> + * parameter is stored, in bytes.
>>> + * @guid_size: Size of the GUID parameter in bytes, i.e.
>>> sizeof(efi_guid_t).
>>> + * @name_offset: Offset from the start of this struct to where the
>>> variable
>>> + * name is stored (as utf-16 string), in bytes.
>>> + * @name_size: Size of the name parameter in bytes, including
>>> null-terminator.
>>> + */
>>> +struct qsee_req_uefi_get_next_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 guid_offset;
>>> + u32 guid_size;
>>> + u32 name_offset;
>>> + u32 name_size;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_rsp_uefi_get_next_variable - Response for the
>>> + * GetNextVariableName command.
>>> + * @command_id: The ID of the command. Should be
>>> + * %QSEE_CMD_UEFI_GET_NEXT_VARIABLE.
>>> + * @length: Length of the response in bytes, including this
>>> struct and any
>>> + * parameters (name, GUID) stored after it as well as
>>> any padding
>>> + * thereof for alignment.
>>> + * @status: Status of this command.
>>> + * @guid_size: Size of the GUID parameter in bytes, i.e.
>>> sizeof(efi_guid_t).
>>> + * @name_offset: Offset from the start of this struct to where the
>>> variable
>>> + * name is stored (as utf-16 string), in bytes.
>>> + * @name_size: Size of the name parameter in bytes, including
>>> null-terminator.
>>> + */
>>> +struct qsee_rsp_uefi_get_next_variable {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 status;
>>> + u32 guid_offset;
>>> + u32 guid_size;
>>> + u32 name_offset;
>>> + u32 name_size;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_req_uefi_query_variable_info - Response for the
>>> + * GetNextVariableName command.
>>> + * @command_id: The ID of the command. Must be
>>> + * %QSEE_CMD_UEFI_QUERY_VARIABLE_INFO.
>>> + * @length: The length of this request, i.e. the size of this
>>> struct in
>>> + * bytes.
>>> + * @attributes: The storage attributes to query the info for.
>>> + */
>>> +struct qsee_req_uefi_query_variable_info {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 attributes;
>>> +} __packed;
>>> +
>>> +/**
>>> + * struct qsee_rsp_uefi_query_variable_info - Response for the
>>> + * GetNextVariableName command.
>>> + * @command_id: The ID of the command. Must be
>>> + * %QSEE_CMD_UEFI_QUERY_VARIABLE_INFO.
>>> + * @length: The length of this response, i.e. the size of
>>> this
>>> + * struct in bytes.
>>> + * @status: Status of this command.
>>> + * @_pad: Padding.
>>> + * @storage_space: Full storage space size, in bytes.
>>> + * @remaining_space: Free storage space available, in bytes.
>>> + * @max_variable_size: Maximum variable data size, in bytes.
>>> + */
>>> +struct qsee_rsp_uefi_query_variable_info {
>>> + u32 command_id;
>>> + u32 length;
>>> + u32 status;
>>> + u32 _pad;
>>> + u64 storage_space;
>>> + u64 remaining_space;
>>> + u64 max_variable_size;
>>> +} __packed;
>>> +
>>> +
>>> +/* -- UEFI app interface.
>>> --------------------------------------------------- */
>>> +
>>> +struct qcuefi_client {
>>> + struct device *dev;
>>> + struct qseecom_device *qsee;
>>> + struct qseecom_dma dma;
>>> + struct efivars efivars;
>>> + u32 app_id;
>>> +};
>>> +
>>> +static efi_status_t qsee_uefi_status_to_efi(u32 status)
>>> +{
>>> + u64 category = status & 0xf0000000;
>>> + u64 code = status & 0x0fffffff;
>>> +
>>> + return category << (BITS_PER_LONG - 32) | code;
>>> +}
>>> +
>>> +static efi_status_t qsee_uefi_get_variable(struct qcuefi_client
>>> *qcuefi, const efi_char16_t *name,
>>> + const efi_guid_t *guid, u32 *attributes,
>>> + unsigned long *data_size, void *data)
>>> +{
>>> + struct qsee_req_uefi_get_variable *req_data;
>>> + struct qsee_rsp_uefi_get_variable *rsp_data;
>>> + struct qseecom_dma dma_req;
>>> + struct qseecom_dma dma_rsp;
>>> + unsigned long name_size = utf16_strsize(name);
>>> + unsigned long buffer_size = *data_size;
>>> + unsigned long size;
>>> + efi_status_t efi_status;
>>> + int status;
>>> +
>>> + /* Validation: We need a name and GUID. */
>>> + if (!name || !guid)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /* Validation: We need a buffer if the buffer_size is nonzero. */
>>> + if (buffer_size && !data)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /* Compute required size (upper limit with alignments). */
>>> + size = sizeof(*req_data) + sizeof(*guid) + name_size /* Inputs. */
>>> + + sizeof(*rsp_data) + buffer_size /*
>>> Outputs. */
>>> + + 2 * (QSEECOM_DMA_ALIGNMENT - 1) /* Input
>>> parameter alignments. */
>>> + + 1 * (QSEECOM_DMA_ALIGNMENT - 1); /* Output
>>> parameter alignments. */
>>
>> Do we need to pack everything into a single DMA buffer? Otherwise it
>> would be better to add qseecom_dma_alloc_aligned function, which will
>> take care of the alignment for a single data piece.
>
> It may be possible to split this into two buffers, one for input and one
> for
> output, but packing of input parameters would still be required (see the
> assignments to req_data below).
>
> For the input, you essentially provide one buffer (address) to qseecom,
> starting with req_data describing the layout in it. This description is
> offset-based, so there's no way to specify multiple addresses/buffers as
> input.
> The output behaves similarly, it's just the secure OS that does the
> packing.
>
> And since we already have to take care of aligning the input parameters,
> I'm
> not sure that it makes sense to split this into two.
I see, thanks for the explanation. Maybe you can add a wrapping call
that will take the sizes of required arguments (as a variadic array?)
and will return prepared req and all the pointers and/or offsets? I
think that having to specify these alignment 'extras' is errror prone.
>
>>
>>> +
>>> + /* Make sure we have enough DMA memory. */
>>> + status = qseecom_dma_realloc(qcuefi->dev, &qcuefi->dma, size,
>>> GFP_KERNEL);
>>
>> This looks like an antipattern. Please allocate the buffer before
>> querrying the data and free it afterwards.
>
> I thought it might make sense to pre-allocate it, but I can change that.
>
>>> + if (status)
>>> + return EFI_OUT_OF_RESOURCES;
>>> +
>>> + /* Align request struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_req, 0);
>>> + req_data = dma_req.virt;
>>> +
>>> + /* Set up request data. */
>>> + req_data->command_id = QSEE_CMD_UEFI_GET_VARIABLE;
>>> + req_data->data_size = buffer_size;
>>> + req_data->name_offset = sizeof(*req_data);
>>> + req_data->name_size = name_size;
>>> + req_data->guid_offset = QSEECOM_DMA_ALIGN(req_data->name_offset
>>> + name_size);
>>> + req_data->guid_size = sizeof(*guid);
>>> + req_data->length = req_data->guid_offset + req_data->guid_size;
>>> +
>>> + dma_req.size = req_data->length;
>>> +
>>> + /* Copy request parameters. */
>>> + utf16_copy_to_buf(dma_req.virt + req_data->name_offset, name,
>>> name_size);
>>> + memcpy(dma_req.virt + req_data->guid_offset, guid,
>>> req_data->guid_size);
>>> +
>>> + /* Align response struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_rsp, req_data->length);
>>> + rsp_data = dma_rsp.virt;
>>> +
>>> + /* Perform SCM call. */
>>> + status = qseecom_app_send(qcuefi->qsee, qcuefi->app_id,
>>> &dma_req, &dma_rsp);
>>> +
>>> + /* Check for errors and validate. */
>>> + if (status)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->command_id != QSEE_CMD_UEFI_GET_VARIABLE)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->length < sizeof(*rsp_data) || rsp_data->length >
>>> dma_rsp.size)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->status) {
>>> + dev_dbg(qcuefi->dev, "%s: uefisecapp error: 0x%x\n",
>>> __func__, rsp_data->status);
>>> + efi_status = qsee_uefi_status_to_efi(rsp_data->status);
>>> +
>>> + /* Update size and attributes in case buffer is too small. */
>>> + if (efi_status == EFI_BUFFER_TOO_SMALL) {
>>> + *data_size = rsp_data->data_size;
>>> + if (attributes)
>>> + *attributes = rsp_data->attributes;
>>> + }
>>> +
>>> + return efi_status;
>>> + }
>>> +
>>> + if (rsp_data->data_offset + rsp_data->data_size > rsp_data->length)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + /* Set attributes and data size even if buffer is too small. */
>>> + *data_size = rsp_data->data_size;
>>> + if (attributes)
>>> + *attributes = rsp_data->attributes;
>>> +
>>> + /*
>>> + * If we have a buffer size of zero and no buffer, just return
>>> + * attributes and required size.
>>> + */
>>> + if (buffer_size == 0 && !data)
>>> + return EFI_SUCCESS;
>>> +
>>> + /* Validate output buffer size. */
>>> + if (buffer_size < rsp_data->data_size)
>>> + return EFI_BUFFER_TOO_SMALL;
>>> +
>>> + /* Copy to output buffer. Note: We're guaranteed to have one at
>>> this point. */
>>> + memcpy(data, dma_rsp.virt + rsp_data->data_offset,
>>> rsp_data->data_size);
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +static efi_status_t qsee_uefi_set_variable(struct qcuefi_client
>>> *qcuefi, const efi_char16_t *name,
>>> + const efi_guid_t *guid, u32 attributes,
>>> + unsigned long data_size, const void *data)
>>> +{
>>> + struct qsee_req_uefi_set_variable *req_data;
>>> + struct qsee_rsp_uefi_set_variable *rsp_data;
>>> + struct qseecom_dma dma_req;
>>> + struct qseecom_dma dma_rsp;
>>> + unsigned long name_size = utf16_strsize(name);
>>> + unsigned long size;
>>> + int status;
>>> +
>>> + /* Validate inputs. */
>>> + if (!name || !guid)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /*
>>> + * Make sure we have some data if data_size is nonzero. Note:
>>> Using a
>>> + * size of zero is valid and deletes the variable.
>>> + */
>>> + if (data_size && !data)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /* Compute required size (upper limit with alignments). */
>>> + size = sizeof(*req_data) + name_size + sizeof(*guid) +
>>> data_size /* Inputs. */
>>> + + sizeof(*rsp_data) /*
>>> Outputs. */
>>> + + 2 * (QSEECOM_DMA_ALIGNMENT - 1) /* Input
>>> parameter alignments. */
>>> + + 1 * (QSEECOM_DMA_ALIGNMENT - 1); /* Output
>>> parameter alignments. */
>>> +
>>> + /* Make sure we have enough DMA memory. */
>>> + status = qseecom_dma_realloc(qcuefi->dev, &qcuefi->dma, size,
>>> GFP_KERNEL);
>>> + if (status)
>>> + return EFI_OUT_OF_RESOURCES;
>>> +
>>> + /* Align request struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_req, 0);
>>> + req_data = dma_req.virt;
>>> +
>>> + /* Set up request data. */
>>> + req_data->command_id = QSEE_CMD_UEFI_SET_VARIABLE;
>>> + req_data->attributes = attributes;
>>> + req_data->name_offset = sizeof(*req_data);
>>> + req_data->name_size = name_size;
>>> + req_data->guid_offset = QSEECOM_DMA_ALIGN(req_data->name_offset
>>> + name_size);
>>> + req_data->guid_size = sizeof(*guid);
>>> + req_data->data_offset = req_data->guid_offset +
>>> req_data->guid_size;
>>> + req_data->data_size = data_size;
>>> + req_data->length = req_data->data_offset + data_size;
>>> +
>>> + /* Copy request parameters. */
>>> + utf16_copy_to_buf(dma_req.virt + req_data->name_offset, name,
>>> req_data->name_size);
>>> + memcpy(dma_req.virt + req_data->guid_offset, guid,
>>> req_data->guid_size);
>>> +
>>> + if (data_size)
>>> + memcpy(dma_req.virt + req_data->data_offset, data,
>>> req_data->data_size);
>>> +
>>> + /* Align response struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_rsp, req_data->length);
>>> + rsp_data = dma_rsp.virt;
>>> +
>>> + /* Perform SCM call. */
>>> + dma_req.size = req_data->length;
>>> + dma_rsp.size = sizeof(*rsp_data);
>>> +
>>> + status = qseecom_app_send(qcuefi->qsee, qcuefi->app_id,
>>> &dma_req, &dma_rsp);
>>> +
>>> + /* Check for errors and validate. */
>>> + if (status)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->command_id != QSEE_CMD_UEFI_SET_VARIABLE)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->length < sizeof(*rsp_data) || rsp_data->length >
>>> dma_rsp.size)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->status) {
>>> + dev_dbg(qcuefi->dev, "%s: uefisecapp error: 0x%x\n",
>>> __func__, rsp_data->status);
>>> + return qsee_uefi_status_to_efi(rsp_data->status);
>>> + }
>>> +
>>> + return EFI_SUCCESS;
>>> +}
>>> +
>>> +static efi_status_t qsee_uefi_get_next_variable(struct qcuefi_client
>>> *qcuefi,
>>> + unsigned long *name_size, efi_char16_t *name,
>>> + efi_guid_t *guid)
>>> +{
>>> + struct qsee_req_uefi_get_next_variable *req_data;
>>> + struct qsee_rsp_uefi_get_next_variable *rsp_data;
>>> + struct qseecom_dma dma_req;
>>> + struct qseecom_dma dma_rsp;
>>> + unsigned long size;
>>> + efi_status_t efi_status;
>>> + int status;
>>> +
>>> + /* We need some buffers. */
>>> + if (!name_size || !name || !guid)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /* There needs to be at least a single null-character. */
>>> + if (*name_size == 0)
>>> + return EFI_INVALID_PARAMETER;
>>> +
>>> + /* Compute required size (upper limit with alignments). */
>>> + size = sizeof(*req_data) + sizeof(*guid) + *name_size /*
>>> Inputs. */
>>> + + sizeof(*rsp_data) + sizeof(*guid) + *name_size /*
>>> Outputs. */
>>> + + 2 * (QSEECOM_DMA_ALIGNMENT - 1) /*
>>> Input parameter alignments. */
>>> + + 1 * (QSEECOM_DMA_ALIGNMENT - 1); /*
>>> Output parameter alignments. */
>>> +
>>> + /* Make sure we have enough DMA memory. */
>>> + status = qseecom_dma_realloc(qcuefi->dev, &qcuefi->dma, size,
>>> GFP_KERNEL);
>>> + if (status)
>>> + return EFI_OUT_OF_RESOURCES;
>>> +
>>> + /* Align request struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_req, 0);
>>> + req_data = dma_req.virt;
>>> +
>>> + /* Set up request data. */
>>> + req_data->command_id = QSEE_CMD_UEFI_GET_NEXT_VARIABLE;
>>> + req_data->guid_offset = QSEECOM_DMA_ALIGN(sizeof(*req_data));
>>> + req_data->guid_size = sizeof(*guid);
>>> + req_data->name_offset = req_data->guid_offset +
>>> req_data->guid_size;
>>> + req_data->name_size = *name_size;
>>> + req_data->length = req_data->name_offset + req_data->name_size;
>>> +
>>> + dma_req.size = req_data->length;
>>> +
>>> + /* Copy request parameters. */
>>> + memcpy(dma_req.virt + req_data->guid_offset, guid,
>>> req_data->guid_size);
>>> + utf16_copy_to_buf(dma_req.virt + req_data->name_offset, name,
>>> *name_size);
>>> +
>>> + /* Align response struct. */
>>> + qseecom_dma_aligned(&qcuefi->dma, &dma_rsp, req_data->length);
>>> + rsp_data = dma_rsp.virt;
>>> +
>>> + /* Perform SCM call. */
>>> + status = qseecom_app_send(qcuefi->qsee, qcuefi->app_id,
>>> &dma_req, &dma_rsp);
>>> +
>>> + /* Check for errors and validate. */
>>> + if (status)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->command_id != QSEE_CMD_UEFI_GET_NEXT_VARIABLE)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->length < sizeof(*rsp_data) || rsp_data->length >
>>> dma_rsp.size)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->status) {
>>> + dev_dbg(qcuefi->dev, "%s: uefisecapp error: 0x%x\n",
>>> __func__, rsp_data->status);
>>> + efi_status = qsee_uefi_status_to_efi(rsp_data->status);
>>> +
>>> + /* Update size with required size in case buffer is too
>>> small. */
>>> + if (efi_status == EFI_BUFFER_TOO_SMALL)
>>> + *name_size = rsp_data->name_size;
>>> +
>>> + return efi_status;
>>> + }
>>> +
>>> + if (rsp_data->name_offset + rsp_data->name_size > rsp_data->length)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->guid_offset + rsp_data->guid_size > rsp_data->length)
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + if (rsp_data->name_size > *name_size) {
>>> + *name_size = rsp_data->name_size;
>>> + return EFI_BUFFER_TOO_SMALL;
>>> + }
>>> +
>>> + if (rsp_data->guid_size != sizeof(*guid))
>>> + return EFI_DEVICE_ERROR;
>>> +
>>> + /* Copy response fields. */
>>> + memcpy(guid, dma_rsp.virt + rsp_data->guid_offset,
>>> rsp_data->guid_size);
>>> + utf16_copy_to_buf(name, dma_rsp.virt + rsp_data->name_offset,
>>> rsp_data->name_size);
>>> + *name_size = rsp_data->name_size;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +
>>> +/* -- Global efivar interface.
>>> ---------------------------------------------- */
>>> +
>>> +static struct qcuefi_client *__qcuefi;
>>> +static DEFINE_MUTEX(__qcuefi_lock);
>>> +
>>> +static int qcuefi_set_reference(struct qcuefi_client *qcuefi)
>>> +{
>>> + mutex_lock(&__qcuefi_lock);
>>> +
>>> + if (qcuefi && __qcuefi) {
>>> + mutex_unlock(&__qcuefi_lock);
>>> + return -EEXIST;
>>> + }
>>> +
>>> + __qcuefi = qcuefi;
>>> +
>>> + mutex_unlock(&__qcuefi_lock);
>>> + return 0;
>>> +}
>>> +
>>> +static struct qcuefi_client *qcuefi_acquire(void)
>>
>> Doesn't this need the __locks annotation? Generally I think it is
>> easier to inline these two functions, there is no particular need to
>> have such wrappers.
>
> Right, I forgot about the annotations.
>
> The idea of those was that it's easier to reason about locking. Anyone
> wanting
> to access __qcuefi outside of these three functions (set, acquire,
> release),
> must go through qcuefi_acquire(), which ensures exclusive access. So
> mistakes
> are a lot more obvious.
Ok.
>
>>> +{
>>> + mutex_lock(&__qcuefi_lock);
>>> + return __qcuefi;
>>> +}
>>> +
>>> +static void qcuefi_release(void)
>>> +{
>>> + mutex_unlock(&__qcuefi_lock);
>>> +}
>>> +
>>> +static efi_status_t qcuefi_get_variable(efi_char16_t *name,
>>> efi_guid_t *vendor, u32 *attr,
>>> + unsigned long *data_size, void *data)
>>> +{
>>> + struct qcuefi_client *qcuefi;
>>> + efi_status_t status;
>>> +
>>> + qcuefi = qcuefi_acquire();
>>> + if (!qcuefi)
>>> + return EFI_NOT_READY;
>>> +
>>> + status = qsee_uefi_get_variable(qcuefi, name, vendor, attr,
>>> data_size, data);
>>> +
>>> + qcuefi_release();
>>> + return status;
>>> +}
>>> +
>>> +static efi_status_t qcuefi_set_variable(efi_char16_t *name,
>>> efi_guid_t *vendor,
>>> + u32 attr, unsigned long data_size, void *data)
>>> +{
>>> + struct qcuefi_client *qcuefi;
>>> + efi_status_t status;
>>> +
>>> + qcuefi = qcuefi_acquire();
>>> + if (!qcuefi)
>>> + return EFI_NOT_READY;
>>> +
>>> + status = qsee_uefi_set_variable(qcuefi, name, vendor, attr,
>>> data_size, data);
>>> +
>>> + qcuefi_release();
>>> + return status;
>>> +}
>>> +
>>> +static efi_status_t qcuefi_get_next_variable(unsigned long
>>> *name_size, efi_char16_t *name,
>>> + efi_guid_t *vendor)
>>> +{
>>> + struct qcuefi_client *qcuefi;
>>> + efi_status_t status;
>>> +
>>> + qcuefi = qcuefi_acquire();
>>> + if (!qcuefi)
>>> + return EFI_NOT_READY;
>>> +
>>> + status = qsee_uefi_get_next_variable(qcuefi, name_size, name,
>>> vendor);
>>> +
>>> + qcuefi_release();
>>> + return status;
>>> +}
>>> +
>>> +static const struct efivar_operations qcom_efivar_ops = {
>>> + .get_variable = qcuefi_get_variable,
>>> + .set_variable = qcuefi_set_variable,
>>> + .get_next_variable = qcuefi_get_next_variable,
>>> +};
>>> +
>>> +
>>> +/* -- Driver setup.
>>> --------------------------------------------------------- */
>>> +
>>> +static int qcom_uefisecapp_probe(struct platform_device *pdev)
>>> +{
>>> + struct qcuefi_client *qcuefi;
>>> + int status;
>>> +
>>> + /* Allocate driver data. */
>>> + qcuefi = devm_kzalloc(&pdev->dev, sizeof(*qcuefi), GFP_KERNEL);
>>> + if (!qcuefi)
>>> + return -ENOMEM;
>>> +
>>> + qcuefi->dev = &pdev->dev;
>>> +
>>> + /* We expect the parent to be the QSEECOM device. */
>>> + qcuefi->qsee = dev_get_drvdata(pdev->dev.parent);
>>> + if (!qcuefi->qsee)
>>> + return -EINVAL;
>>> +
>>> + /* Get application id for uefisecapp. */
>>> + status = qseecom_app_get_id(qcuefi->qsee, QSEE_UEFISEC_APP_NAME,
>>> &qcuefi->app_id);
>>> + if (status) {
>>> + dev_err(&pdev->dev, "failed to query app ID: %d\n", status);
>>> + return status;
>>> + }
>>> +
>>> + /* Set up DMA. One page should be plenty to start with. */
>>
>> one page?
>
> The driver I've reverse-engineered this from allocates the DMA memory for
> interaction with qseecom in multiples of PAGE_SIZE. I'm following that
> in this
> driver, as I don't know whether that's a hard requirement (at least on some
> platforms) or not. So I pre-allocate one page (1x PAGE_SIZE bytes) here.
> But as
> you've mentioned above, it might be better to allocate this on-demand in
> each
> call.
Probably the comment was misplaced. It talks about 1 page, but it is
placed right before a call to dma_set_mask rather than dma_alloc.
>
>>> + if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(64))) {
>>> + dev_warn(&pdev->dev, "no suitable DMA available\n");
>>> + return -EFAULT;
>>> + }
>>> +
>>> + status = qseecom_dma_alloc(&pdev->dev, &qcuefi->dma, PAGE_SIZE,
>>> GFP_KERNEL);
>>> + if (status)
>>> + return status;
>>> +
>>> + /* Register global reference. */
>>> + platform_set_drvdata(pdev, qcuefi);
>>> + status = qcuefi_set_reference(qcuefi);
>>> + if (status)
>>> + goto free;
>>> +
>>> + /* Register efivar ops. */
>>> + status = efivars_register(&qcuefi->efivars, &qcom_efivar_ops);
>>> + if (status)
>>> + goto clear_reference;
>>> +
>>> + return 0;
>>> +
>>> +clear_reference:
>>> + qcuefi_set_reference(NULL);
>>> +free:
>>> + qseecom_dma_free(qcuefi->dev, &qcuefi->dma);
>>> + return status;
>>> +}
>>> +
>>> +static int qcom_uefisecapp_remove(struct platform_device *pdev)
>>> +{
>>> + struct qcuefi_client *qcuefi = platform_get_drvdata(pdev);
>>> +
>>> + /* Unregister efivar ops. */
>>> + efivars_unregister(&qcuefi->efivars);
>>> +
>>> + /* Block on pending calls and unregister global reference. */
>>> + qcuefi_set_reference(NULL);
>>> +
>>> + /* Free remaining resources. */
>>> + qseecom_dma_free(qcuefi->dev, &qcuefi->dma);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static struct platform_driver qcom_uefisecapp_driver = {
>>> + .probe = qcom_uefisecapp_probe,
>>> + .remove = qcom_uefisecapp_remove,
>>> + .driver = {
>>> + .name = "qcom_qseecom_uefisecapp",
>>> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
>>> + },
>>> +};
>>> +module_platform_driver(qcom_uefisecapp_driver);
>>> +
>>> +MODULE_AUTHOR("Maximilian Luz <luzmaximilian@...il.com>");
>>> +MODULE_DESCRIPTION("Client driver for Qualcomm SEE UEFI Secure App");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:qcom_qseecom_uefisecapp");
>>
--
With best wishes
Dmitry
Powered by blists - more mailing lists