linux-kernel - Re: [PATCH V2] nvmem: add explicit config option to read OF fixed cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230309094010.1051573-1-michael@walle.cc>
Date:   Thu,  9 Mar 2023 10:40:10 +0100
From:   Michael Walle <michael@...le.cc>
To:     zajec5@...il.com
Cc:     a.zummo@...ertech.it, agross@...nel.org,
        alexandre.belloni@...tlin.com, alexandre.torgue@...s.st.com,
        alyssa@...enzweig.io, andersson@...nel.org,
        angelogioacchino.delregno@...labora.com, asahi@...ts.linux.dev,
        baolin.wang@...ux.alibaba.com, claudiu.beznea@...rochip.com,
        festevam@...il.com, hayashi.kunihiko@...ionext.com,
        heiko@...ech.de, jbrunet@...libre.com, jernej.skrabec@...il.com,
        kernel@...gutronix.de, khilman@...libre.com,
        konrad.dybcio@...aro.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-mtd@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
        linux-rtc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-sunxi@...ts.linux.dev, marcan@...can.st,
        martin.blumenstingl@...glemail.com, matthias.bgg@...il.com,
        mcoquelin.stm32@...il.com, mhiramat@...nel.org,
        michal.simek@...inx.com, miquel.raynal@...tlin.com,
        neil.armstrong@...aro.org, orsonzhai@...il.com, rafal@...ecki.pl,
        richard@....at, s.hauer@...gutronix.de, samuel@...lland.org,
        shawnguo@...nel.org, srinivas.kandagatla@...aro.org,
        sven@...npeter.dev, vigneshr@...com, vincent.sunplus@...il.com,
        wens@...e.org, zbr@...emap.net, zhang.lyra@...il.com,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH V2] nvmem: add explicit config option to read OF fixed cells

[as this mentions  nvmem layouts it would have been nice to include me]

> NVMEM subsystem looks for fixed NVMEM cells (specified in DT) by
> default. This behaviour made sense in early days before adding support
> for dynamic cells.

Why is that? It still makes sense, doesn't it?

> With every new supported NVMEM device with dynamic cells current
> behaviour becomes non-optimal. It results in unneeded iterating over DT
> nodes and may result in false discovery of cells (depending on used DT
> properties).

What false discoveries?

> This behaviour has actually caused a problem already with the MTD
> subsystem. MTD subpartitions were incorrectly treated as NVMEM cells.

But this is solved, correct?

> Also with upcoming support for NVMEM layouts no new binding or driver
> should support fixed cells defined in device node.

How would you support older device trees with newer kernels or the
other way around? I'm not sure I get your motivation to drop handling
the fixed cells.

> Solve this by modifying drivers for bindings that support specifying
> fixed NVMEM cells in DT. Make them explicitly tell NVMEM subsystem to
> read cells from DT.

How can a driver know when there are fixed cells and when not? IOW.
only new ones can be affected.

If you want to get rid of the schema for *new* drivers then what
about having a new child node, something like "nvmem-fixed-cells",
similar to "nvmem-layout".

And then you'd tell the new drivers to use the new-style dt binding. But
there are no new drivers yet. So I'm still not sure I get your motivation.

-michael