linux-kernel - Re: [PATCH -next] staging: most: dim2: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97c60193-4462-1a09-c3e6-235c57a844fd@microchip.com>
Date:   Thu, 9 Mar 2023 12:07:25 +0000
From:   <Parthiban.Veerasooran@...rochip.com>
To:     <yang.lee@...ux.alibaba.com>
CC:     <Christian.Gromm@...rochip.com>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] staging: most: dim2: Use
 devm_platform_get_and_ioremap_resource()

On 08/03/23 12:06 pm, Yang Li wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
Acked-by: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>
> ---
>   drivers/staging/most/dim2/dim2.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 7a5f80e637a0..b8bd01ca1f11 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -775,8 +775,7 @@ static int dim2_probe(struct platform_device *pdev)
>                  goto err_free_dev;
>          }
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       dev->io_base = devm_ioremap_resource(&pdev->dev, res);
> +       dev->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>          if (IS_ERR(dev->io_base)) {
>                  ret = PTR_ERR(dev->io_base);
>                  goto err_free_dev;
> --
> 2.20.1.7.g153144c
>