[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <738921f2-0ec6-9418-2b6a-8df2a2e95130@starfivetech.com>
Date: Thu, 9 Mar 2023 10:22:49 +0800
From: Jack Zhu <jack.zhu@...rfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"Mauro Carvalho Chehab" <mchehab@...nel.org>,
Robert Foss <rfoss@...nel.org>,
Todor Tomov <todor.too@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Maxime Ripard <mripard@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>, <changhuang.liang@...rfivetech.com>
Subject: Re: [PATCH v1 10/11] media: uapi: add user space interfaces
On 2023/3/3 16:44, Krzysztof Kozlowski wrote:
> On 02/03/2023 10:19, jack.zhu wrote:
>> This patch adds user space interfaces for ISP.
>
> Do not use "This commit/patch".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
OK, I will fix it.
>
> Why this is a separate commit? User-space API is usually added with its
> implementation. Otherwise how does your code even compile?
>
OK, I will merge them.
thank you for your comments.
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists