linux-kernel - Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Mar 2023 14:56:31 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-gpio@...r.kernel.org,
        linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

Hi Adrian,

> On Thu, 2023-03-09 at 14:52 +0100, Geert Uytterhoeven wrote:
> > shx3_defconfig:
> >
> >     arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
> >     arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
> >       246 |                 baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
> >         |                                                              ^
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com
> > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

> > --- a/arch/sh/boards/mach-x3proto/setup.c
> > +++ b/arch/sh/boards/mach-x3proto/setup.c
> > @@ -17,6 +17,7 @@
> >  #include <linux/usb/r8a66597.h>
> >  #include <linux/usb/m66592.h>
> >  #include <linux/gpio.h>
> > +#include <linux/gpio/driver.h>
> >  #include <linux/gpio_keys.h>
> >  #include <mach/ilsel.h>
> >  #include <mach/hardware.h>
>
> Thanks. You were much faster than me. I didn't even have the time to have a look
> at the problem yet ;-). Is it sufficient to pick this up for 6.4?

As the problem is introduced in and only found in gpio/for-next,
I expect Linus or Andy to pick it up.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds