linux-kernel - Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5b6077c-1e6e-43fe-8f83-ca7019d4a43d@sirena.org.uk>
Date:   Thu, 9 Mar 2023 14:04:28 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lucas Tanure <lucas.tanure@...labora.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai --cc=alsa-devel @ alsa-project . org" <tiwai@...e.com>,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties
 quirk

On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> On 09/03/2023 11:41, Lucas Tanure wrote:

> > -	ret = device_property_read_u32(dev, "cirrus,boost-type", &val);
> > -	if (ret >= 0)
> > -		hw_cfg->bst_type = val;
> > +	if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {

> You are now changing ABI and adding undocumented properties.

Note also that this doesn't change the existing property, it continues
to work identically.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)