linux-kernel - Re: [PATCH] scsi: message: fusion: avoid flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167841804068.2362455.8672714577251900437.b4-ty@oracle.com>
Date:   Thu,  9 Mar 2023 22:14:23 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Sathya Prakash <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: message: fusion: avoid flush_scheduled_work() usage

On Wed, 22 Feb 2023 00:02:46 +0900, Tetsuo Handa wrote:

> Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a
> macro") says, flush_scheduled_work() is dangerous and will be forbidden.
> 
> Commit 4d4109d0eb69 ("[SCSI] mpt fusion: Power Management fixes for MPT
> SAS PCI-E controllers") added flush_scheduled_work() call into
> mptscsih_suspend(). As of commit 4d4109d0eb69, there were several
> schedule{,_delayed}_work() calls where flush_scheduled_work() from
> mptscsih_suspend() meant to wait for completion, but which work items
> is this flush_scheduled_work() call for was not explained.
> 
> [...]

Applied to 6.4/scsi-queue, thanks!

[1/1] scsi: message: fusion: avoid flush_scheduled_work() usage
      https://git.kernel.org/mkp/scsi/c/a4c2673caed9

-- 
Martin K. Petersen	Oracle Linux Engineering