linux-kernel - Re: [PATCH v5 0/2] Apple Magic Keyboard Backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MA0P287MB021727E7ED58C8C74F879CE4B8BA9@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Date:   Fri, 10 Mar 2023 16:16:11 +0000
From:   Aditya Garg <gargaditya08@...e.com>
To:     Jiri Kosina <jikos@...nel.org>
CC:     Orlando Chamberlain <orlandoch.dev@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Pavel Machek <pavel@....cz>, Aun-Ali Zaidi <admin@...eit.net>,
        Kerem Karabay <kekrby@...il.com>,
        Andy Shevchenko <andy@...radead.org>,
        Thomas Weißschuh <thomas@...ch.de>
Subject: Re: [PATCH v5 0/2] Apple Magic Keyboard Backlight

> Hi,
> 
> thanks for creating the support for backlight.
> 
> Is there any reason why not to fold all this into existing hid-apple? I 
> don't think we need separate driver for the backlist, separated from the 
> rest of hid-apple support.
> 
> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 

As far as I know, hid-apple manages the keyboards and trackpads on Macs.

The magic backlight is managed by the touchbar on T2 Macs, so if you wanna integrate the driver in some other one, then it should be the to-be-upstreamed touchbar driver.

But when we did that, the MacBook Air 2020, the model which has magic backlight, but no touchbar faced issues. lsusb interestingly shows presence of touch bar backlight even on this model, but backlight is registered at the 0th interface on Air, and 1st interface on the Pros. So, the co-author, Kerem Karabay suggested using a separate driver.

Although, the authors may give more detailed reason for the same.